Review main Merged

65225[BUGFIX] Improve usage of 3rd party modules in TypeScript context

Andreas Kienast CR +2 V +2 Hard +268 −267 updated 08/08/20, 13:29

Commit message

This changes the configuration of the TypeScript compiler to resolve
modules in "node" style, which allows using TypeScript declaration files
(*.d.ts) shipped with npm packages.

Additionally the option "esModuleInterop" is enabled which allows us to
use CommonJS modules in AMD modules without fiddling with incompatible
exports.

As a negative side-effect, all JavaScript have to get recompiled to
reflect these changes.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 259

Show 239 more files

Review log 45

  1. Andreas Kienast uploaded patch set 1 08/07/20, 17:46

  2. TYPO3com voted on patch set 1 V +1 08/07/20, 17:58 Completed build in 11m 17s on Fri, 7 Aug, 05:58 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4490

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/08/20, 13:12

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/08/20, 13:29

  5. Anja Leichsenring merged patch set 2 08/08/20, 13:29