Review 10.4 Merged

65226[BUGFIX] Improve usage of 3rd party modules in TypeScript context

Andreas Kienast CR +2 V +2 Hard +288 −287 updated 07/05/22, 13:24

Commit message

This changes the configuration of the TypeScript compiler to resolve
modules in "node" style, which allows using TypeScript declaration files
(*.d.ts) shipped with npm packages.

Additionally the option "esModuleInterop" is enabled which allows us to
use CommonJS modules in AMD modules without fiddling with incompatible
exports.

As a negative side-effect, all JavaScript have to get recompiled to
reflect these changes.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 279

Show 259 more files

Review log 45

  1. Andreas Kienast uploaded patch set 1 08/08/20, 13:20

  2. TYPO3com voted on patch set 1 V +1 08/08/20, 13:32 Completed build in 12m 09s on Sat, 8 Aug, 01:32 PM Test Summary: 74009 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-187

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/08/20, 13:45

  4. Anja Leichsenring merged patch set 2 08/08/20, 13:45

  5. Oliver Hader commented on patch set 2 06/02/22, 10:51

    DragUploader.ts:362 Unresolved