65228[TASK] Replace deprecated library "cropper" with "cropperjs"
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 11
- Build/Sources/Sass/cropper/_utilities.scss+0 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ImageManipulation.ts+63 −99
- Build/Gruntfile.js+1 −1
- Build/package.json+1 −1
- Build/yarn.lock+5 −7
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ImageManipulation/ImageManipulationWizard.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ImageManipulation.js+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/cropper.min.js+5 −5
Review log 2128
Show 23 earlier messages
-
Andreas Kienast uploaded patch set 1 08/09/20, 11:17
-
Andreas Kienast updated the commit message in patch set 2 08/09/20, 11:22
-
TYPO3com voted on patch set 1 V +1 08/09/20, 11:29 Completed build in 11m 13s on Sun, 9 Aug, 11:29 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4518
-
Andreas Kienast uploaded patch set 3 08/09/20, 11:32
-
TYPO3com voted on patch set 2 V +1 08/09/20, 11:33 Completed build in 11m 08s on Sun, 9 Aug, 11:33 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4519
-
TYPO3com voted on patch set 3 V +1 08/09/20, 11:43 Completed build in 10m 56s on Sun, 9 Aug, 11:43 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4520
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 08/09/20, 12:06
-
Daniel Haupt commented on patch set 3 V -1 08/09/20, 15:58
The "Selected Size" value within the modal is not working anymore (showing only "NaN×NaN px"). -
Andreas Kienast commented on patch set 3 CR -1 08/10/20, 05:29
> Patch Set 3: Verified-1 > > The "Selected Size" value within the modal is not working anymore (showing only "NaN×NaN px"). Good catch, thanks! -
Andreas Kienast uploaded patch set 4 08/10/20, 05:36
-
Andreas Kienast uploaded patch set 5 08/10/20, 05:39
-
TYPO3com voted on patch set 4 V +1 08/10/20, 05:49 Completed build in 13m 19s on Mon, 10 Aug, 05:49 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4529
-
TYPO3com voted on patch set 5 V +1 08/10/20, 05:54 Completed build in 14m 57s on Mon, 10 Aug, 05:54 AM Test Summary: 72969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4530
-
Daniel Haupt voted on patch set 5 V +1 CR +1 08/10/20, 10:23
-
Anja Leichsenring commented on patch set 5 V -1 08/12/20, 18:15
not sure it is related, but I get an error: - open any CE with an image, invoke the cropper func - push the cropping area around, click accept - see Error Uncaught TypeError: e.attr is not a function in ImageManipulation.js:13:14083 -
Andreas Kienast commented on patch set 5 08/12/20, 18:40
> Patch Set 5: Verified-1 > > not sure it is related, but I get an error: > > - open any CE with an image, invoke the cropper func > - push the cropping area around, click accept > - see Error > > Uncaught TypeError: e.attr is not a function in ImageManipulation.js:13:14083 Interesting, I‘ll have a look -
Andreas Kienast uploaded patch set 6 08/13/20, 05:12
-
Andreas Kienast commented on patch set 6 V -1 08/13/20, 05:19
Restoring the cropping configuration from an unsaved content element is not possible right now -
Anja Leichsenring commented on patch set 6 08/13/20, 05:21
at least my error is gone now :) -
TYPO3com voted on patch set 6 V +1 08/13/20, 05:23 Completed build in 11m 23s on Thu, 13 Aug, 05:23 AM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4608
-
Andreas Kienast commented on patch set 6 08/13/20, 06:28
Alright, it seems the move handler is invoked multiple times on initialization -
Andreas Kienast uploaded patch set 7 08/14/20, 13:17
-
TYPO3com voted on patch set 7 V +1 08/14/20, 13:28 Completed build in 10m 59s on Fri, 14 Aug, 01:28 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4660
-
Anja Leichsenring voted on patch set 7 V +1 08/15/20, 14:29
-
Christian Kuhn voted on patch set 7 V +1 08/15/20, 14:56
-
Christian Kuhn voted on patch set 7 CR +1 08/15/20, 14:57
-
Anja Leichsenring voted on patch set 7 V +2 CR +2 08/15/20, 14:57
-
Anja Leichsenring merged patch set 8 08/15/20, 14:57