Review main Merged

65229[BUGFIX] Avoid empty cache identifiers

Simon Gilli CR +2 V +2 Normal +51 −1 updated 08/10/20, 16:19

Commit message

Currently it is possible to add an invalid cache configuration with
empty identifiers. This change avoids this behavior by checking the
indentifiers while changing the cache configuration at the
CacheManager.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Daniel Haupt +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1316

  1. Simon Gilli uploaded patch set 1 08/09/20, 14:19

  2. Simon Gilli commented on patch set 1 CR -1 08/09/20, 14:21

    tests are still missing
  3. Oliver Klee commented on patch set 1 08/09/20, 14:23

    Can we cover this with tests?
  4. TYPO3com voted on patch set 1 V +1 08/09/20, 14:31 Completed build in 11m 19s on Sun, 9 Aug, 02:31 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4522

  5. Simon Gilli uploaded patch set 2 08/09/20, 15:30

  6. Simon Gilli commented on patch set 2 08/09/20, 15:31

    > Patch Set 1: > > Can we cover this with tests? Yes, have a look at my last comment. That was the reason for my -1 and is now solved :)
  7. TYPO3com voted on patch set 2 V +1 08/09/20, 15:41 Completed build in 10m 45s on Sun, 9 Aug, 03:41 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4523

  8. Oliver Klee commented on patch set 2 CR +1 08/09/20, 16:01

    Beautiful!
  9. Daniel Haupt voted on patch set 2 V +1 CR +1 08/09/20, 16:44

  10. Christian Kuhn uploaded patch set 3 08/10/20, 11:33

  11. Christian Kuhn commented on patch set 3 V +1 CR +1 08/10/20, 11:34

    Fine with me. I removed v9 though: The issue is not critical and the method is quite different in v9.
  12. TYPO3com voted on patch set 3 V +1 08/10/20, 11:44 Completed build in 10m 36s on Mon, 10 Aug, 11:44 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4546

  13. Oliver Klee voted on patch set 3 CR +1 08/10/20, 11:46

  14. Daniel Haupt voted on patch set 3 V +1 CR +1 08/10/20, 13:16

  15. Benni Mack voted on patch set 3 V +2 CR +2 08/10/20, 16:19

  16. Benni Mack merged patch set 4 08/10/20, 16:19