65229[BUGFIX] Avoid empty cache identifiers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Daniel Haupt +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Haupt +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 1316
-
Simon Gilli uploaded patch set 1 08/09/20, 14:19
-
Simon Gilli commented on patch set 1 CR -1 08/09/20, 14:21
tests are still missing -
Oliver Klee commented on patch set 1 08/09/20, 14:23
Can we cover this with tests? -
TYPO3com voted on patch set 1 V +1 08/09/20, 14:31 Completed build in 11m 19s on Sun, 9 Aug, 02:31 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4522
-
Simon Gilli uploaded patch set 2 08/09/20, 15:30
-
Simon Gilli commented on patch set 2 08/09/20, 15:31
> Patch Set 1: > > Can we cover this with tests? Yes, have a look at my last comment. That was the reason for my -1 and is now solved :) -
TYPO3com voted on patch set 2 V +1 08/09/20, 15:41 Completed build in 10m 45s on Sun, 9 Aug, 03:41 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4523
-
Oliver Klee commented on patch set 2 CR +1 08/09/20, 16:01
Beautiful! -
Daniel Haupt voted on patch set 2 V +1 CR +1 08/09/20, 16:44
-
Christian Kuhn uploaded patch set 3 08/10/20, 11:33
-
Christian Kuhn commented on patch set 3 V +1 CR +1 08/10/20, 11:34
Fine with me. I removed v9 though: The issue is not critical and the method is quite different in v9. -
TYPO3com voted on patch set 3 V +1 08/10/20, 11:44 Completed build in 10m 36s on Mon, 10 Aug, 11:44 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4546
-
Oliver Klee voted on patch set 3 CR +1 08/10/20, 11:46
-
Daniel Haupt voted on patch set 3 V +1 CR +1 08/10/20, 13:16
-
Benni Mack voted on patch set 3 V +2 CR +2 08/10/20, 16:19
-
Benni Mack merged patch set 4 08/10/20, 16:19