Review main Merged

65230[BUGFIX] Skip processing of inline children which aren't workspace-aware

Christian Kuhn CR +2 V +2 Normal +121 −0 updated 08/10/20, 14:41

Commit message

When dealing with inline foreign field setups in workspaces
and having a child table not workspace aware, the DataHandler
still tries to create workspace copies of the not workspace
aware child.

In v9, it sets pid=-1 for those records, which succeeds if the
pid db field is signed. In this case a dead record of the
child is created. If the field is unsigned, the insertion fails
and an error message is created.

In v10 and master pid=-1 is gone and the real pid is set, the
record is created and becomes a 1:1 duplicate in live workspace.

The patch adds an according check to the DataHandler in
workspace context to skip not workspace aware children.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • David Steeb +1
  • Verified V +2 Done
    • Benni Mack +2
    • David Steeb +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1116

  1. Christian Kuhn uploaded patch set 1 08/09/20, 15:57

  2. TYPO3com voted on patch set 1 V +1 08/09/20, 16:09 Completed build in 11m 10s on Sun, 9 Aug, 04:08 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4524

  3. Christian Kuhn commented on patch set 1 CR -1 08/09/20, 16:11

    unsure on how to cover this with tests: we need a scenario where parent table *is* workspace aware, while the child is not. with irre_tutorial all are ws aware, but there might be away around in the testing-framework.
  4. Christian Kuhn uploaded patch set 2 08/09/20, 17:07

  5. Christian Kuhn uploaded patch set 3 08/09/20, 17:08

  6. TYPO3com voted on patch set 2 V -1 08/09/20, 17:08 Completed build in 30s on Sun, 9 Aug, 05:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4525

  7. TYPO3com voted on patch set 3 V +1 08/09/20, 17:19 Completed build in 10m 44s on Sun, 9 Aug, 05:19 PM Test Summary: 72974 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4526

  8. Christian Kuhn commented on patch set 3 CR -1 08/10/20, 09:48

    will add another test case
  9. Christian Kuhn uploaded patch set 4 08/10/20, 10:41

  10. Oliver Klee commented on patch set 4 08/10/20, 10:48

    Unresolved

    I had to read this subject line with its double negation to times, and I still am not sure I have understood it correctly. Would it make sense to change this to "workspace-agnostic children" (also in the lines below)?
  11. Benni Mack updated the commit message in patch set 5 08/10/20, 10:50

  12. TYPO3com voted on patch set 4 V +1 08/10/20, 10:53 Completed build in 11m 45s on Mon, 10 Aug, 10:53 AM Test Summary: 72977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4542

  13. TYPO3com voted on patch set 5 V +1 08/10/20, 11:02 Completed build in 11m 50s on Mon, 10 Aug, 11:02 AM Test Summary: 72977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4544

  14. David Steeb voted on patch set 5 V +1 CR +1 08/10/20, 14:39

  15. Benni Mack voted on patch set 5 V +2 CR +2 08/10/20, 14:41

  16. Benni Mack merged patch set 6 08/10/20, 14:41