Review 9.5 Merged

65233[BUGFIX] Allow routes without actual route variables for ExtbaseEnhancer

Oliver Hader CR +2 V +2 Easy +3 −1 updated 08/10/20, 20:22

Commit message

The route configuration shown below using `ExtbaseEnhancer` is currently
not evaluated anymore due to missing route variables in `routePath`. For
this particular case in `ExtbaseEnhancer` the controller-action pair is
implicitly defining variables.

MyPlugin:
  type: Extbase
  extension: ...
  plugin: ...
  routes:
    -
      routePath: '/action'
      _controller: 'MyController::action'

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 08/10/20, 09:30

  2. TYPO3com voted on patch set 1 V +1 08/10/20, 09:43 Completed build in 12m 22s on Mon, 10 Aug, 09:43 AM Test Summary: 75127 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-751

  3. Georg Ringer voted on patch set 1 CR +1 08/10/20, 11:08

  4. Oliver Hader voted on patch set 1 V +2 CR +2 08/10/20, 20:22

  5. Oliver Hader merged patch set 2 08/10/20, 20:22