Review main Merged

65234[BUGFIX] Fix ObjectAccess::isPropertyGettable for ArrayAccess objects

Alexander Schnitzler CR +2 V +2 Easy +36 −7 updated 09/17/20, 18:59

Commit message

While introducing symfony/property-access, method isPropertyGettable
of class ObjectAccess had been adjusted in a manner which made the
mixed usage of array access and regular property access impossible.

If an object implemented ArrayAccess and used regular properties,
all of those properties were reported inacessible/non-gettable which
is not true.

With this patch, regular properties and those defined magically
via ArrayAccess are detected correctly as gettable.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Alexander Schnitzler uploaded patch set 1 08/10/20, 09:31

  2. Alexander Schnitzler wrote 08/10/20, 09:32

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V -1 08/10/20, 09:48 Completed build in 14m 30s on Mon, 10 Aug, 09:48 AM Test Summary: 36 of 73461 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4536

  4. Alexander Schnitzler uploaded patch set 2 08/10/20, 09:58

  5. TYPO3com voted on patch set 2 V +1 08/10/20, 10:10 Completed build in 12m 03s on Mon, 10 Aug, 10:10 AM Test Summary: 72977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4540

  6. Alexander Schnitzler commented on patch set 2 08/10/20, 10:15

    This change is ready for review.
  7. Wouter Wolters voted on patch set 2 CR +1 08/10/20, 18:31

  8. Till Wimmer voted on patch set 2 V +1 CR +1 08/13/20, 12:29

  9. Anja Leichsenring uploaded patch set 3 09/02/20, 17:16

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/02/20, 17:16

  11. TYPO3com voted on patch set 3 V +1 09/02/20, 17:29 Completed build in 13m 02s on Wed, 2 Sep, 05:29 PM Test Summary: 73188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5150

  12. Anja Leichsenring updated the commit message in patch set 4 09/08/20, 19:47

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 09/08/20, 19:47

  14. Anja Leichsenring commented on patch set 4 09/08/20, 19:48

    not to 9.5 for two reasons: - it is not critical - the offending patch, that introduced the issue, never was backported to 9 ;)
  15. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/08/20, 19:51

  16. TYPO3com voted on patch set 4 V +1 09/08/20, 19:59 Completed build in 12m 00s on Tue, 8 Sep, 07:59 PM Test Summary: 73179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5379

  17. Jörg Bösche voted on patch set 4 CR +1 09/09/20, 07:13

  18. Anja Leichsenring voted on patch set 4 V +2 CR +2 09/17/20, 18:58

  19. Anja Leichsenring merged patch set 5 09/17/20, 18:59