65236[BUGFIX] Ensure correct loading order in ModuleTemplate
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Marcus Schwemer +1
-
Verified V +2 Done
- Daniel Goerz +2
- Marcus Schwemer +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 911
-
Benni Mack uploaded patch set 1 08/10/20, 10:21
-
TYPO3com voted on patch set 1 V +1 08/10/20, 10:33 Completed build in 12m 17s on Mon, 10 Aug, 10:33 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4541
-
Marcus Schwemer commented on patch set 1 V -1 08/10/20, 12:13
Thanks. Still does not work, when using the fluid backend container viewhelper "f:be.container" and the argument "includeCssFiles". -
Marcus Schwemer uploaded patch set 2 08/11/20, 06:31
-
Marcus Schwemer commented on patch set 2 08/11/20, 06:40
After thinking about it again ... -
Marcus Schwemer commented on patch set 2 08/11/20, 06:41
> Patch Set 2: > > After thinking about it again ... Would it be better to split that into two patches? One for f:be.container and one for the ModuleTemplate? -
TYPO3com voted on patch set 2 V +1 08/11/20, 06:42 Completed build in 10m 24s on Tue, 11 Aug, 06:42 AM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4560
-
Benni Mack commented on patch set 2 08/11/20, 08:32
> Patch Set 2: > > > Patch Set 2: > > > > After thinking about it again ... > Would it be better to split that into two patches? One for f:be.container and one for the ModuleTemplate? Not really, this change shows exactly the issue and both places are needed to fix the issue you reported. -
Marcus Schwemer voted on patch set 2 V +1 CR +1 08/14/20, 08:03
-
Daniel Goerz voted on patch set 2 V +2 CR +2 08/22/20, 11:47
-
Daniel Goerz merged patch set 3 08/22/20, 11:47