Review 10.4 Abandoned

65239[BUGFIX] ISO Date Format Year-M-D with SYS Global Format

TYPO3com CR 0 V 0 Normal +95 −29 updated 12/08/20, 19:52

Commit message

TYPO3 configuration knows a global date format configuration
within the installation tool. See TYPO3_CONF_VARS/SYS/ddmmyy

Most countries prefer the Year-Month-Day date format and
not the UK/US style Month-Day->Year.

Change the initialization of the DateTimePicker accordingly.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 68

  1. TYPO3com uploaded patch set 1 08/10/20, 11:00

  2. TYPO3com voted on patch set 1 V -1 08/10/20, 11:03 Completed build in 02m 30s on Mon, 10 Aug, 11:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-195

  3. david wong commented on patch set 1 V +1 CR +1 08/10/20, 11:04

  4. Oliver Hader commented on patch set 1 08/10/20, 13:44

  5. Anja Leichsenring commented on patch set 1 11/11/20, 20:50

    this change is strange. Target is master, but it resides on branch 10.4. The js changes must be done in TypeScript. Can someone please pick that up? Or abandon, if not?
  6. Anja Leichsenring voted on patch set 1 CR -1 11/11/20, 20:50

  7. Andreas Kienast commented on patch set 1 CR -1 11/12/20, 07:16

    I prefer to abandon this change. IMO it's plain wrong to introduce yet *another* hardcoded date format and make date handling more complex. I'd really love to see just *one* configuration: a simple string containing format options usable by strftime(), which can be configured to whatever an integrator pleases to.
  8. Anja Leichsenring abandoned the change 12/08/20, 19:52

    Please don't be mad at me, but this change has no chance of getting merged. If you want to work on it again and need help, please ask in TYPO3 Slack for guidance. We happily support you.