Review 9.5 Merged

65242[BUGFIX] Ensure decoded parameters are a valid array

Oliver Hader CR +2 V +2 Easy +1 −1 updated 08/10/20, 19:44

Commit message

Calling ShowImageController with old links containing serialized
parameters leads to PHP warnings as the json_decode doesn't
return an array in this case.

To prevent this warnings we now ensure that parameters is a valid
array in any case, prior to calling the foreach.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 08/10/20, 13:33

  2. TYPO3com voted on patch set 1 V +1 08/10/20, 13:49 Completed build in 13m 17s on Mon, 10 Aug, 01:49 PM Test Summary: 75127 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-752

  3. Oliver Klee voted on patch set 1 CR +1 08/10/20, 15:59

  4. Oliver Hader voted on patch set 1 V +2 CR +2 08/10/20, 19:44

  5. Oliver Hader merged patch set 2 08/10/20, 19:44