Review main Abandoned

65244[BUGFIX] Use proper method in OptgroupViewHelper for adding attributes

Georg Ringer CR 0 V 0 Normal +69 −1 updated 10/08/21, 08:14

Commit message

To add an attribute, the method `addAttribute` must be used instead of
`addAttributes`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 67

  1. Georg Ringer uploaded patch set 1 08/10/20, 18:22

  2. Georg Ringer commented on patch set 1 08/10/20, 18:22

    This change is ready for review.
  3. Wouter Wolters voted on patch set 1 CR +1 08/10/20, 18:24

  4. TYPO3com voted on patch set 1 V +1 08/10/20, 18:33 Completed build in 11m 19s on Mon, 10 Aug, 06:33 PM Test Summary: 72995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4552

  5. Benni Mack commented on patch set 1 08/11/20, 05:48

    OptgroupViewHelper.php:48 Unresolved

    this whole thing seems superfluous. Why would we want to use an argumnet "disabled" if we actually have a Tag Attribute registered "disabled"?
  6. Benni Mack commented on patch set 1 06/14/21, 11:17

    Unresolved

    ping. Any answer to my question?
  7. Georg Ringer abandoned the change 10/08/21, 08:14

    solved with #92656