Review 9.5 Merged

65253[BUGFIX] Skip processing of inline children which aren't workspace-aware

Benni Mack CR +2 V +2 Normal +121 −0 updated 08/10/20, 16:09

Commit message

When dealing with inline foreign field setups in workspaces
and having a child table not workspace aware, the DataHandler
still tries to create workspace copies of the not workspace
aware child.

In v9, it sets pid=-1 for those records, which succeeds if the
pid db field is signed. In this case a dead record of the
child is created. If the field is unsigned, the insertion fails
and an error message is created.

In v10 and master pid=-1 is gone and the real pid is set, the
record is created and becomes a 1:1 duplicate in live workspace.

The patch adds an according check to the DataHandler in
workspace context to skip not workspace aware children.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 57

  1. Benni Mack commented on patch set 1 08/10/20, 15:31

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/AbstractActionTestCase.php * typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/ActionTest.php * typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/AbstractActionTestCase.php * typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/ActionTest.php
  2. Benni Mack commented on patch set 1 08/10/20, 15:32

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 08/10/20, 15:44 Completed build in 12m 38s on Mon, 10 Aug, 03:44 PM Test Summary: 6 of 75733 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-753

  4. Christian Kuhn uploaded patch set 2 08/10/20, 15:52

  5. TYPO3com voted on patch set 2 V +1 08/10/20, 16:04 Completed build in 12m 04s on Mon, 10 Aug, 04:04 PM Test Summary: 75133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-754

  6. Benni Mack voted on patch set 2 V +2 CR +2 08/10/20, 16:09

  7. Benni Mack merged patch set 3 08/10/20, 16:09