Review main Abandoned

65275[TASK] Code cleanup in ExtensionListCommand

Sybille Peters CR 0 V 0 Easy +1 −3 updated 08/11/20, 14:20

Commit message

This commits removes duplicate code in ExtensionListCommand. This should
make the code better readable.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Sybille Peters uploaded patch set 1 08/11/20, 13:02

  2. Benni Mack commented on patch set 1 CR -1 08/11/20, 13:11

    ExtensionListCommand.php:77

    hey Sybille, there is a difference in the three lines before your change vs. the line you added.
  3. Benni Mack commented on patch set 1 CR 0 08/11/20, 13:11

    nevermind
  4. Benni Mack commented on patch set 1 08/11/20, 13:12

    ExtensionListCommand.php:77 Reply

    Done
  5. TYPO3com voted on patch set 1 V +1 08/11/20, 13:13 Completed build in 11m 27s on Tue, 11 Aug, 01:13 PM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4572

  6. Mathias Brodala voted on patch set 1 CR +1 08/11/20, 13:15

  7. Oliver Klee voted on patch set 1 CR +1 08/11/20, 13:57

  8. Sybille Peters abandoned the change 08/11/20, 14:20