Review main Merged

65277[BUGFIX] Extract width and height meta data for all image files

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 08/14/20, 06:38

Commit message

Instead of looking at the mime type of the file, the configured
image file extensions is checked to decide whether to extract
width and height for sys_file_metadata.

This allows pdf files to have their width and height to be extracted.

While the exact pixel values do not matter much for a PDF,
the ratio of width and height (landscape or portrait or even square)
can be very useful to "know".

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Simon Praetorius +1
    • Tim Schreiner +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Tim Schreiner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Helmut Hummel uploaded patch set 1 08/11/20, 14:13

  2. Helmut Hummel wrote 08/11/20, 14:13

    Topic set to image-processing
  3. TYPO3com voted on patch set 1 V +1 08/11/20, 14:26 Completed build in 13m 02s on Tue, 11 Aug, 02:26 PM Test Summary: 72987 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4574

  4. Simon Praetorius commented on patch set 1 CR +1 08/11/20, 14:37

    lgtm
  5. Tim Schreiner commented on patch set 1 V +1 CR +1 08/11/20, 17:44

    Also tested with large PDFs (> 100Mb)
  6. Markus Klein commented on patch set 1 08/12/20, 06:50

    So you assume that all configured imagefile_ext can actually be processed by IM/GM/... Is this a safe assumption? If yes, cool.
  7. Helmut Hummel commented on patch set 1 08/13/20, 14:06

    > Patch Set 1: > > So you assume that all configured imagefile_ext can actually be processed by IM/GM/... > Is this a safe assumption? If yes, cool. yes, this is assumed in the image processing anyway. actually it is the point of this configuration, to pass all files with these extensions through IM/GM during processing
  8. Markus Klein voted on patch set 1 V +1 CR +1 08/13/20, 17:56

  9. Georg Ringer voted on patch set 1 V +2 CR +2 08/14/20, 06:37

  10. Georg Ringer merged patch set 2 08/14/20, 06:38