Review main Merged

65278[BUGFIX] Properly render IRRE image thumbnail

Helmut Hummel CR +2 V +2 Easy +7 −6 updated 08/22/20, 13:26

Commit message

Use IMAGECROPSCALEMASK to render IRRE thumbnails,
so that the crop area is properly respected and
the TCA configuration for the rendering is applied as well.

Also fix the resolving of the crop area, which remained
undiscovered, as the crop configuration is ignored
with IMAGEPREVIEW processing.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Markus Klein +1
    • Anja Leichsenring +1
    • Simon Praetorius +1
    • Tim Schreiner +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Tim Schreiner +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 910

  1. Helmut Hummel uploaded patch set 1 08/11/20, 14:25

  2. Helmut Hummel wrote 08/11/20, 14:26

    Topic set to image-processing
  3. TYPO3com voted on patch set 1 V +1 08/11/20, 14:37 Completed build in 11m 47s on Tue, 11 Aug, 02:37 PM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4575

  4. Simon Praetorius commented on patch set 1 CR +1 08/11/20, 14:42

    lgtm
  5. Tim Schreiner voted on patch set 1 V +1 CR +1 08/11/20, 17:34

  6. Markus Klein voted on patch set 1 CR +1 08/12/20, 07:17

  7. Christian Kuhn voted on patch set 1 V +1 CR +1 08/22/20, 13:14

  8. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/22/20, 13:26

  9. Helmut Hummel voted on patch set 1 V +2 CR +2 08/22/20, 13:26

  10. Helmut Hummel merged patch set 2 08/22/20, 13:26