65281[TASK] Use frontend requests when testing canonical URL behavior
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Markus Klein +1
- Richard Haeser +1
-
Verified V +2 Done
- Oliver Hader +2
- Markus Klein +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1014
-
Oliver Hader uploaded patch set 1 08/11/20, 15:37
-
TYPO3com voted on patch set 1 V -1 08/11/20, 15:52 Completed build in 15m 18s on Tue, 11 Aug, 03:52 PM Test Summary: 22 of 73470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4582
-
Oliver Hader uploaded patch set 2 08/11/20, 16:01
-
Oliver Hader commented on patch set 2 08/11/20, 16:12
-
TYPO3com voted on patch set 2 V +1 08/11/20, 16:12 Completed build in 11m 26s on Tue, 11 Aug, 04:12 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4584
-
Christian Kuhn voted on patch set 2 V +1 CR +1 08/11/20, 16:13
-
Richard Haeser commented on patch set 2 CR -1 08/11/20, 19:05
CanonicalGeneratorTest.php:108UnresolvedWe should not request http://localhost/dummy-1-2 here, but we should request http://localhost/dummy-1-3. That URL should return a canonical http://localhost/dummy-1-2. Now you are just checking the same url over and over. Will add a new patchsetCanonicalGeneratorTest.php:119Reply UnresolvedI think it is quite ok that you get a 404 as there is no content to show. At least this is the current behaviour, so totally fine to remove this check. -
Richard Haeser uploaded patch set 3 08/11/20, 19:12
-
TYPO3com voted on patch set 3 V -1 08/11/20, 19:23 Completed build in 11m 06s on Tue, 11 Aug, 07:23 PM Test Summary: 1 of 73470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4585
-
Richard Haeser voted on patch set 3 V +1 CR +1 08/11/20, 19:28
-
TYPO3com voted on patch set 3 V +1 08/11/20, 19:32 Completed build in 10m 57s on Tue, 11 Aug, 07:32 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4586
-
Markus Klein voted on patch set 3 V +1 CR +1 08/12/20, 06:43
-
Oliver Hader voted on patch set 3 V +2 CR +2 08/12/20, 09:41
-
Oliver Hader merged patch set 4 08/12/20, 09:41
CanonicalGeneratorTest.php:119