Review main Merged

65284[BUGFIX] Drop "LIVE workspace" tab from workspace module

Christian Kuhn CR +2 V +2 Easy +7 −3 updated 08/12/20, 12:01

Commit message

The "LIVE workspace" tab of the workspace module always
showed wrong records from other workspaces. This issue
has been resolved with the pid=-1 removal in v10.

Since then, this tab never shows records. The patch
removes the tab from the interface. Users, including
admins, now see a "Please select a workspace first"
message when calling the module in online / live
workspace.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 58

  1. Christian Kuhn uploaded patch set 1 08/11/20, 22:55

  2. Christian Kuhn uploaded patch set 2 08/11/20, 22:59

  3. TYPO3com voted on patch set 1 V +1 08/11/20, 23:08 Completed build in 12m 23s on Tue, 11 Aug, 11:08 PM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4587

  4. TYPO3com voted on patch set 2 V -1 08/11/20, 23:40 Completed build in 40m 52s on Tue, 11 Aug, 11:40 PM Test Summary: 83 of 70708 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4588

  5. TYPO3com voted on patch set 2 V +1 08/12/20, 04:44 Completed build in 6h 25m 48s on Wed, 12 Aug, 04:44 AM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4588

  6. Achim Fritz voted on patch set 2 V +1 CR +1 08/12/20, 09:46

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 08/12/20, 12:01

  8. Andreas Kienast merged patch set 3 08/12/20, 12:01