Review main Merged

65286[BUGFIX] Render placeholder attribute for readonly fields

Georg Ringer CR +2 V +2 Easy +2 −1 updated 08/18/20, 18:25

Commit message

Readonly relations to sys_file_reference records should still
show the placeholder values which is filled by the meta data
coming from sys_file_metadata.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 08/12/20, 06:47

  2. Georg Ringer commented on patch set 1 08/12/20, 06:48

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 08/12/20, 06:58 Completed build in 10m 51s on Wed, 12 Aug, 06:58 AM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4591

  4. Benni Mack voted on patch set 1 V +1 CR +1 08/14/20, 10:20

  5. Daniel Windloff voted on patch set 1 V +1 CR +1 08/14/20, 15:18

  6. Daniel Haupt voted on patch set 1 CR +1 08/16/20, 11:46

  7. Christian Kuhn commented on patch set 1 08/18/20, 14:59

    InputTextElement.php:102 Unresolved

    i guess we should apply a trim() as it is done with the non-readonly placeholder handling below.
  8. Christian Kuhn commented on patch set 1 CR -1 08/18/20, 15:02

    working on it.
  9. Christian Kuhn commented on patch set 1 08/18/20, 15:30

    Styleguide: Added inline_2 to inline_fal example to show this scenario in styleguide master & 10. Note some metadata has to be added to one of the styleguide example images first. The generator should do that automatically though, which will be handled in styleguide with https://github.com/TYPO3/styleguide/issues/158
  10. Christian Kuhn uploaded patch set 2 08/18/20, 15:31

  11. Christian Kuhn voted on patch set 2 V +1 CR +1 08/18/20, 15:31

  12. Christian Kuhn commented on patch set 2 08/18/20, 15:34

    InputTextElement.php:300 Unresolved

    this is a drive-by change. hope that is ok.
  13. TYPO3com voted on patch set 2 V +1 08/18/20, 15:42 Completed build in 11m 10s on Tue, 18 Aug, 03:42 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4761

  14. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/18/20, 18:25

  15. Anja Leichsenring merged patch set 3 08/18/20, 18:25