Review main Merged

65289[BUGFIX] Output messages and progress for language:update

Helmut Hummel CR +2 V +2 Normal +47 −16 updated 09/01/20, 06:12

Commit message

Always output a progress bar and information that it is
actually doing something even when not called with --verbose

When no output is required or wanted, the global option --quiet
can be used instead.

To further improve the command, --no-progress is added
which removes the progress bar output, and shows messages instead.

Last but not least, output success or error messages for each
of the language pack fetches and exit with error code when
failures occurred.

To not make the command always fail when private extensions are used,
individual extensions can be skipped.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 813

  1. Helmut Hummel uploaded patch set 1 08/12/20, 15:20

  2. TYPO3com voted on patch set 1 V -1 08/12/20, 15:20 Completed build in 23s on Wed, 12 Aug, 03:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4600

  3. Georg Ringer commented on patch set 1 CR -1 08/12/20, 16:52

    Imo 9 should be avoided and I would like to see an info for skip-extension that this is a list of extension keys
  4. Helmut Hummel commented on patch set 1 08/17/20, 11:41

    > Patch Set 1: Code-Review-1 > > Imo 9 should be avoided Why? > and I would like to see an info for skip-extension that this is a list of extension keys That standard symfony/console functionality and shown in the help that extension-key can be specified multiple times
  5. Helmut Hummel updated the commit message in patch set 2 08/27/20, 13:37

  6. TYPO3com voted on patch set 2 V -1 08/27/20, 13:38 Completed build in 25s on Thu, 27 Aug, 01:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5015

  7. Helmut Hummel uploaded patch set 3 08/27/20, 13:39

  8. TYPO3com voted on patch set 3 V -1 08/27/20, 13:50 Completed build in 11m 33s on Thu, 27 Aug, 01:50 PM Test Summary: 35 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5016

  9. TYPO3com commented on patch set 3 08/31/20, 10:03 Completed build in 11m 21s on Mon, 31 Aug, 10:03 AM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5075

  10. TYPO3com voted on patch set 3 V +1 08/31/20, 10:27 Completed build in 47m 14s on Mon, 31 Aug, 10:27 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5075

  11. Jörg Bösche voted on patch set 3 V +1 CR +1 08/31/20, 10:28

  12. Benni Mack voted on patch set 3 V +2 CR +2 09/01/20, 06:12

  13. Benni Mack merged patch set 4 09/01/20, 06:12