Review main Merged

65290[TASK] Remove workaround for testing-framework from Services.yaml

Anja Leichsenring CR +2 V +2 Hard +359 −14 updated 08/23/20, 20:32

Commit message

By having testing-framework load ext:fluid by default for functional
tests, the workaround of disabling autowiring for TemplateView class
can be removed. DI is now available for TemplateView class as
expected.

used command:
 composer require --dev typo3/testing-framework:^6.4

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 812

  1. Anja Leichsenring uploaded patch set 1 08/12/20, 16:12

  2. TYPO3com voted on patch set 1 V -1 08/12/20, 16:23 Completed build in 11m 16s on Wed, 12 Aug, 04:23 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4601

  3. Anja Leichsenring uploaded patch set 2 08/12/20, 16:25

  4. Benjamin Franzke commented on patch set 2 CR +1 08/12/20, 16:35

    Thank you for picking this up, looks good from my side (once testing framework version is bumped).
  5. TYPO3com voted on patch set 2 V +1 08/12/20, 16:37 Completed build in 11m 37s on Wed, 12 Aug, 04:37 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4602

  6. Anja Leichsenring uploaded patch set 3 08/23/20, 18:24

  7. Anja Leichsenring updated the commit message in patch set 4 08/23/20, 18:27

  8. TYPO3com voted on patch set 3 V +1 08/23/20, 18:36 Completed build in 11m 29s on Sun, 23 Aug, 06:36 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4881

  9. TYPO3com voted on patch set 4 V +1 08/23/20, 18:40 Completed build in 12m 44s on Sun, 23 Aug, 06:40 PM Test Summary: 73073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4882

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 08/23/20, 19:15

  11. Benjamin Franzke voted on patch set 4 V +2 CR +2 08/23/20, 20:32

  12. Benjamin Franzke merged patch set 5 08/23/20, 20:32