65291[TASK] Use DI in command classes where applicable
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Richard Haeser +2
- Christian Kuhn +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/Command/ResetPasswordCommand.php1+19 −4
- typo3/sysext/core/Classes/Command/ExtensionListCommand.php+15 −6
- typo3/sysext/core/Classes/Command/SiteShowCommand.php+12 −2
- typo3/sysext/extensionmanager/Classes/Command/DeactivateExtensionCommand.php+0 −5
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+13 −3
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+12 −2
- typo3/sysext/lowlevel/Classes/Command/FilesWithMultipleReferencesCommand.php1+18 −3
- typo3/sysext/lowlevel/Classes/Command/LostFilesCommand.php+10 −1
- typo3/sysext/lowlevel/Classes/Command/MissingFilesCommand.php+11 −2
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+11 −2
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+12 −3
- typo3/sysext/redirects/Classes/Command/CheckIntegrityCommand.php2+20 −6
- typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php+6 −3
- typo3/sysext/workspaces/Classes/Command/AutoPublishCommand.php1+19 −5
- typo3/sysext/workspaces/Classes/Command/CleanupPreviewLinksCommand.php+11 −2
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+19 −9
Review log 1523
-
Anja Leichsenring uploaded patch set 1 08/12/20, 17:43
-
Anja Leichsenring updated the commit message in patch set 2 08/12/20, 17:43
-
TYPO3com voted on patch set 1 V -1 08/12/20, 17:43 Completed build in 26s on Wed, 12 Aug, 05:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4603
-
TYPO3com voted on patch set 2 V -1 08/12/20, 17:44 Completed build in 23s on Wed, 12 Aug, 05:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4604
-
Anja Leichsenring uploaded patch set 3 08/12/20, 17:51
-
TYPO3com voted on patch set 3 V -1 08/12/20, 17:52 Completed build in 22s on Wed, 12 Aug, 05:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4605
-
Anja Leichsenring uploaded patch set 4 08/12/20, 17:52
-
TYPO3com voted on patch set 4 V +1 08/12/20, 18:03 Completed build in 10m 41s on Wed, 12 Aug, 06:03 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4606
-
Benjamin Franzke uploaded patch set 5 2 comments 08/13/20, 14:12
-
TYPO3com voted on patch set 5 V +1 08/13/20, 14:25 Completed build in 12m 49s on Thu, 13 Aug, 02:25 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4635
-
Anja Leichsenring uploaded patch set 6 08/14/20, 06:55
-
TYPO3com voted on patch set 6 V +1 08/14/20, 07:06 Completed build in 11m 31s on Fri, 14 Aug, 07:06 AM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4650
-
Christian Kuhn commented on patch set 6 CR -1 08/15/20, 13:11
-
Anja Leichsenring uploaded patch set 7 08/15/20, 13:14
-
TYPO3com voted on patch set 7 V +1 08/15/20, 13:25 Completed build in 10m 43s on Sat, 15 Aug, 01:24 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4696
-
Christian Kuhn commented on patch set 7 V +1 CR +1 08/15/20, 13:26
tested all commands -
Andreas Kienast commented on patch set 7 CR -1 08/15/20, 17:35
on itResetPasswordCommand.php:90UnresolvedCan be injected as wellFilesWithMultipleReferencesCommand.php:221UnresolvedBasicFileUtility could be injected as well -
Andreas Kienast uploaded patch set 8 08/15/20, 17:35
-
Andreas Kienast voted on patch set 8 V +1 CR +1 08/15/20, 17:41
-
TYPO3com voted on patch set 8 V +1 08/15/20, 17:46 Completed build in 11m 02s on Sat, 15 Aug, 05:46 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4704
-
Christian Kuhn voted on patch set 8 V +1 CR +1 08/16/20, 13:54
-
Richard Haeser voted on patch set 8 V +2 CR +2 08/17/20, 18:31
-
Richard Haeser merged patch set 9 08/17/20, 18:31
CheckIntegrityCommand.php:40Unresolved