Review main Merged

65291[TASK] Use DI in command classes where applicable

Anja Leichsenring CR +2 V +2 Hard +208 −58 updated 08/17/20, 18:31

Commit message

Constructor Injection should be used when an object needs to
be available that is a singleton. This is now done in all
command classes

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 1523

  1. Anja Leichsenring uploaded patch set 1 08/12/20, 17:43

  2. Anja Leichsenring updated the commit message in patch set 2 08/12/20, 17:43

  3. TYPO3com voted on patch set 1 V -1 08/12/20, 17:43 Completed build in 26s on Wed, 12 Aug, 05:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4603

  4. TYPO3com voted on patch set 2 V -1 08/12/20, 17:44 Completed build in 23s on Wed, 12 Aug, 05:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4604

  5. Anja Leichsenring uploaded patch set 3 08/12/20, 17:51

  6. TYPO3com voted on patch set 3 V -1 08/12/20, 17:52 Completed build in 22s on Wed, 12 Aug, 05:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4605

  7. Anja Leichsenring uploaded patch set 4 08/12/20, 17:52

  8. TYPO3com voted on patch set 4 V +1 08/12/20, 18:03 Completed build in 10m 41s on Wed, 12 Aug, 06:03 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4606

  9. Benjamin Franzke uploaded patch set 5 2 comments 08/13/20, 14:12

  10. TYPO3com voted on patch set 5 V +1 08/13/20, 14:25 Completed build in 12m 49s on Thu, 13 Aug, 02:25 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4635

  11. Anja Leichsenring uploaded patch set 6 08/14/20, 06:55

  12. TYPO3com voted on patch set 6 V +1 08/14/20, 07:06 Completed build in 11m 31s on Fri, 14 Aug, 07:06 AM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4650

  13. Christian Kuhn commented on patch set 6 CR -1 08/15/20, 13:11

    CheckIntegrityCommand.php:40 Unresolved

    this one is not injected.
  14. Anja Leichsenring uploaded patch set 7 08/15/20, 13:14

  15. TYPO3com voted on patch set 7 V +1 08/15/20, 13:25 Completed build in 10m 43s on Sat, 15 Aug, 01:24 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4696

  16. Christian Kuhn commented on patch set 7 V +1 CR +1 08/15/20, 13:26

    tested all commands
  17. Andreas Kienast commented on patch set 7 CR -1 08/15/20, 17:35

    on it

    ResetPasswordCommand.php:90 Unresolved

    Can be injected as well

    FilesWithMultipleReferencesCommand.php:221 Unresolved

    BasicFileUtility could be injected as well
  18. Andreas Kienast uploaded patch set 8 08/15/20, 17:35

  19. Andreas Kienast voted on patch set 8 V +1 CR +1 08/15/20, 17:41

  20. TYPO3com voted on patch set 8 V +1 08/15/20, 17:46 Completed build in 11m 02s on Sat, 15 Aug, 05:46 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4704

  21. Christian Kuhn voted on patch set 8 V +1 CR +1 08/16/20, 13:54

  22. Richard Haeser voted on patch set 8 V +2 CR +2 08/17/20, 18:31

  23. Richard Haeser merged patch set 9 08/17/20, 18:31