Review 10.4 Merged

65296[BUGFIX] Extract width and height meta data for all image files

Georg Ringer CR +2 V +2 Easy +1 −1 updated 08/14/20, 09:25

Commit message

Instead of looking at the mime type of the file, the configured
image file extensions is checked to decide whether to extract
width and height for sys_file_metadata.

This allows pdf files to have their width and height to be extracted.

While the exact pixel values do not matter much for a PDF,
the ratio of width and height (landscape or portrait or even square)
can be very useful to "know".

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 08/14/20, 06:38

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/14/20, 06:49 Completed build in 11m 27s on Fri, 14 Aug, 06:49 AM Test Summary: 74024 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-210

  3. Helmut Hummel voted on patch set 1 V +2 CR +2 08/14/20, 09:25

  4. Helmut Hummel merged patch set 2 08/14/20, 09:25