Review 10.4 Merged

65303[BUGFIX] Drop 'List View' in workspace preview

Benni Mack CR +2 V +2 Normal +4 −84 updated 08/18/20, 06:49

Commit message

The workspace preview not only has the default view with
the slider to show differences between live and workspace
version. It additionally contains a full workspace module
accessible through the 'List View' button.
This view is notoriously broken and not fully thought through.
For instance the 'Open version of page' button breaks out of
the module to a different place of the backend, restricted to
the main module frame, and there is no way back.
For simple workspace stage editing, the default preview
mode has the 'send to stage' and 'discards' buttons already,
so there is little reason to have the backend module rendered
in the preview in the first place.
The patch drops the 'List View' from the preview. Next to
a cleaner interface, this increases the performance of the
preview since a full backend call plus various ajax calls
are no longer executed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 35

  1. Benni Mack commented on patch set 1 08/17/20, 21:51

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/17/20, 22:05 Completed build in 14m 19s on Mon, 17 Aug, 10:05 PM Test Summary: 7 of 74520 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-230

  3. TYPO3com voted on patch set 1 V +1 08/18/20, 06:49 Completed build in 9h 11m 55s on Tue, 18 Aug, 06:49 AM Test Summary: 74036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-230

  4. Benni Mack voted on patch set 1 V +2 CR +2 08/18/20, 06:49

  5. Benni Mack merged patch set 2 08/18/20, 06:49