Review main Merged

65312[TASK] Remove IE workaround in AbstractUserAuthentication

Torben Hansen CR +2 V +2 Easy +5 −30 updated 09/11/20, 09:42

Commit message

The workaround in AbstractUserAuthentication targets versions
of Internet Explorer 6, which are not supported by TYPO3 nor by
Microsoft any more.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Torben Hansen +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1721

  1. Torben Hansen uploaded patch set 1 08/13/20, 06:23

  2. TYPO3com voted on patch set 1 V -1 08/13/20, 06:35 Completed build in 11m 56s on Thu, 13 Aug, 06:35 AM Test Summary: 71643 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4609

  3. Benni Mack commented on patch set 1 08/13/20, 06:38

    Hi Torben, I came across this piece of code multiple times in the past years, and always wondered if we should remove it. Thanks for tackling it. Some remarks: a) I know there are some IE-compat modes flying around (IE11 simulating IE-X behavior) in corporations b) There is another piece of code (I believe in EXT:frontend/RequestHandler.php) which also deals with IE-compat, maybe we can remove that part at the same time. Maybe you can add a bit of proof in the Commit Message when support was dropped? Beware: Even if IE6 support was dropped for TYPO3 Backend, TYPO3 Frontend does not care about dropped IE versions.
  4. Benni Mack rebased onto patch set 2 09/10/20, 09:42

  5. Benni Mack updated the commit message in patch set 3 09/10/20, 19:55

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 20:18 Completed build in 18m 26s on Thu, 10 Sep, 08:18 PM Test Summary: 73167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5522

  7. Benni Mack commented on patch set 4 09/10/20, 20:24

    Published edit on patch set 3.
  8. Benni Mack voted on patch set 4 V +1 CR +1 09/10/20, 20:24

  9. TYPO3com voted on patch set 4 V +1 09/10/20, 20:50 Completed build in 17m 58s on Thu, 10 Sep, 08:50 PM Test Summary: 73167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5526

  10. Torben Hansen voted on patch set 4 CR +1 09/11/20, 05:20

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 09/11/20, 06:09

  12. Jörg Bösche voted on patch set 4 CR +1 09/11/20, 06:12

  13. Benni Mack commented on patch set 4 09/11/20, 06:26

    Torben, is it OK if we only do this in v11?
  14. Torben Hansen commented on patch set 4 09/11/20, 06:49

    > Patch Set 4: > > Torben, is it OK if we only do this in v11? Yes.
  15. Benni Mack updated the commit message in patch set 5 09/11/20, 08:14

  16. Jörg Bösche voted on patch set 5 CR +1 09/11/20, 08:18

  17. TYPO3com voted on patch set 5 V +1 09/11/20, 08:30 Completed build in 14m 14s on Fri, 11 Sep, 08:30 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5531

  18. Torben Hansen voted on patch set 5 CR +1 09/11/20, 08:32

  19. Oli Bartsch voted on patch set 5 V +1 CR +1 09/11/20, 08:37

  20. Benni Mack voted on patch set 5 V +2 CR +2 09/11/20, 09:42

  21. Benni Mack merged patch set 6 09/11/20, 09:42