Review main Merged

65316[BUGFIX] Add absolute URL generation to f:widget.link

Johannes Rebhan CR +2 V +2 Easy +2 −0 updated 08/31/20, 13:03

Commit message

This adds the missing ability to generate absolute URLs
with the f:widget.link ViewHelper, which is possible
with other linking ViewHelpers as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 712

  1. Johannes Rebhan uploaded patch set 1 08/13/20, 09:08

  2. Daniel Siepmann voted on patch set 1 CR +1 08/13/20, 09:13

  3. TYPO3com voted on patch set 1 V -1 08/13/20, 10:00 Completed build in 51m 22s on Thu, 13 Aug, 10:00 AM Test Summary: 72551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4612

  4. TYPO3com commented on patch set 1 08/26/20, 15:07 Completed build in 20m 34s on Wed, 26 Aug, 03:07 PM Test Summary: 2 of 73578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4993

  5. TYPO3com voted on patch set 1 V +1 08/31/20, 11:17 Completed build in 12m 03s on Mon, 31 Aug, 11:17 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5081

  6. Benni Mack updated the commit message in patch set 2 08/31/20, 12:22

  7. Benni Mack updated the commit message in patch set 3 08/31/20, 12:22

  8. TYPO3com voted on patch set 2 V +1 08/31/20, 12:34 Completed build in 11m 56s on Mon, 31 Aug, 12:34 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5085

  9. TYPO3com voted on patch set 3 V +1 08/31/20, 12:39 Completed build in 16m 41s on Mon, 31 Aug, 12:39 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5086

  10. Jörg Bösche voted on patch set 3 V +1 CR +1 08/31/20, 12:44

  11. Benni Mack voted on patch set 3 V +2 CR +2 08/31/20, 13:03

  12. Benni Mack merged patch set 4 08/31/20, 13:03