65317[FEATURE] Allow ordering of displayed columns in redirects overview
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Feature-91890-ColumnOrderingInRedirectsOverview.rstnew+15 −0
- typo3/sysext/redirects/Classes/Repository/Demand.php1+67 −50
- typo3/sysext/redirects/Classes/Repository/RedirectRepository.php1+10 −3
- typo3/sysext/redirects/Resources/Private/Language/locallang_module_redirect.xlf+5 −2
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+24 −6
- typo3/sysext/redirects/Tests/Unit/Repository/DemandTest.php+8 −8
Review log 2840
Show 1015 earlier messages
-
Benjamin Serfhos uploaded patch set 1 08/13/20, 10:25
-
TYPO3com voted on patch set 1 V -1 08/13/20, 10:36 Completed build in 11m 01s on Thu, 13 Aug, 10:36 AM Test Summary: 72982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4614
-
Benjamin Serfhos uploaded patch set 2 08/13/20, 11:47
-
Benjamin Serfhos uploaded patch set 3 08/13/20, 11:48
-
TYPO3com voted on patch set 2 V -1 08/13/20, 11:59 Completed build in 12m 03s on Thu, 13 Aug, 11:59 AM Test Summary: 10 of 73470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4616
-
TYPO3com voted on patch set 3 V +1 08/13/20, 12:03 Completed build in 14m 54s on Thu, 13 Aug, 12:03 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4617
-
Benjamin Serfhos uploaded patch set 4 08/13/20, 13:02
-
TYPO3com voted on patch set 4 V +1 08/13/20, 13:15 Completed build in 12m 36s on Thu, 13 Aug, 01:15 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4625
-
Benjamin Serfhos uploaded patch set 5 08/13/20, 13:15
-
TYPO3com voted on patch set 5 V +1 08/13/20, 13:28 Completed build in 12m 44s on Thu, 13 Aug, 01:28 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4627
-
Benjamin Serfhos wrote 08/13/20, 13:33
Hashtag added: ext:redirects -
Benjamin Serfhos wrote 08/13/20, 13:33
Hashtag removed: ext:redirects -
Benjamin Serfhos wrote 08/13/20, 13:33
Hashtag added: redirects -
Benjamin Serfhos wrote 08/13/20, 13:34
Hashtag removed: redirects -
Benjamin Serfhos wrote 08/13/20, 13:34
Hashtag added: ext:redirects
-
Daniel Windloff commented on patch set 5 V -1 CR -1 08/14/20, 16:23
I've tested with current master. * The sorting does not work (remove orderBy and replace ->addOrderBy) * The sorting does not take the filter into account (like Source Host). The filter jumped back after sorting. * The possible fields and directions for the sorting (->orderBy) must be filtered.Demand.php:109UnresolvedFilter possible order directions / order fieds. The QueryInterface belongs to the Extbase context, the query not.RedirectRepository.php:80UnresolvedThis is user input without treatment -> security. -
Benjamin Serfhos commented on patch set 5 08/17/20, 08:06
> Patch Set 5: Verified-1 Code-Review-1 > > (2 comments) > > I've tested with current master. > > * The sorting does not work (remove orderBy and replace ->addOrderBy) > * The sorting does not take the filter into account (like Source Host). The filter jumped back after sorting. > * The possible fields and directions for the sorting (->orderBy) must be filtered. Thanks! Will try to solve all the feedback today! -
Benjamin Serfhos uploaded patch set 6 08/17/20, 14:04
-
TYPO3com voted on patch set 6 V +1 08/17/20, 14:16 Completed build in 11m 31s on Mon, 17 Aug, 02:16 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4733
-
Daniel Windloff commented on patch set 6 CR -1 08/17/20, 16:14
On it -
Daniel Windloff uploaded patch set 7 08/17/20, 16:20
-
TYPO3com voted on patch set 7 V +1 08/17/20, 16:31 Completed build in 11m 00s on Mon, 17 Aug, 04:31 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4736
-
Daniel Windloff voted on patch set 7 V +1 CR +1 08/17/20, 16:31
-
Jörg Bösche voted on patch set 7 CR +1 08/26/20, 14:01
-
Daniel Goerz commented on patch set 7 CR -1 09/20/20, 13:45
on it -
Daniel Goerz uploaded patch set 8 09/20/20, 14:27
-
TYPO3com voted on patch set 8 V -1 09/20/20, 14:28 Completed build in 24s on Sun, 20 Sep, 02:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5763
-
Daniel Goerz uploaded patch set 9 09/20/20, 14:30
-
TYPO3com voted on patch set 9 V -1 09/20/20, 14:42 Completed build in 11m 53s on Sun, 20 Sep, 02:42 PM Test Summary: 48 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5764
-
Daniel Goerz uploaded patch set 10 09/20/20, 15:11
-
TYPO3com voted on patch set 10 V -1 09/20/20, 15:11 Completed build in 23s on Sun, 20 Sep, 03:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5766
-
Daniel Goerz uploaded patch set 11 09/20/20, 15:13
-
TYPO3com voted on patch set 11 V +1 09/20/20, 15:24 Completed build in 11m 03s on Sun, 20 Sep, 03:24 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5767
-
Daniel Goerz voted on patch set 11 V +1 CR +1 09/20/20, 15:33
-
Daniel Goerz uploaded patch set 12 09/21/20, 08:35
-
Daniel Goerz voted on patch set 12 V +1 CR +1 09/21/20, 08:36
-
Oli Bartsch voted on patch set 12 V +1 CR +1 09/21/20, 08:42
-
TYPO3com voted on patch set 12 V +1 09/21/20, 08:46 Completed build in 10m 39s on Mon, 21 Sep, 08:46 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5781
-
Benni Mack voted on patch set 12 V +2 CR +2 09/21/20, 13:29
-
Benni Mack merged patch set 13 09/21/20, 13:29