Review main Merged Breaking

65318[!!!][TASK] Remove support for swapping instead of publishing workspace records

Benni Mack CR +2 V +2 Hard +331 −399 updated 09/05/20, 11:34

Commit message

The functionality of "exchanging" a versioned record in a workspace with
a live version, is not used, and has certain downsides (e.g. it is not clear
what exchange happened, not event stream to understand when
was what changed, and especially when swapping single/selected items
multiple times it gets really messy). Also, swapping is conceptually
not working (when activated) for newly created records and leaves an
inconsistent state. For these reasons, the feature is dropped.

What was removed:
* The option sys_workspace.swap_modes
* The option to only swap on auto-publish
* The option to swap in workspace module

In the future it would be really beneficial to rename internal "swap"
variables to "publish" to streamline this logic.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 29

Show 9 more files

Review log 2131

Show 36 earlier messages
  1. Benni Mack uploaded patch set 1 08/13/20, 11:50

  2. TYPO3com voted on patch set 1 V -1 08/13/20, 12:06 Completed build in 13m 09s on Thu, 13 Aug, 12:06 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4618

  3. Benni Mack uploaded patch set 2 08/13/20, 12:22

  4. TYPO3com voted on patch set 2 V +1 08/13/20, 12:34 Completed build in 11m 06s on Thu, 13 Aug, 12:34 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4621

  5. Benni Mack uploaded patch set 3 08/31/20, 20:16

  6. TYPO3com voted on patch set 3 V +1 08/31/20, 20:32 Completed build in 16m 02s on Mon, 31 Aug, 08:32 PM Test Summary: 73145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5092

  1. Benni Mack uploaded patch set 4 09/04/20, 09:41

  2. TYPO3com voted on patch set 4 V +1 09/04/20, 09:54 Completed build in 12m 32s on Fri, 4 Sep, 09:54 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5224

  3. Benni Mack uploaded patch set 5 09/04/20, 11:17

  4. TYPO3com voted on patch set 5 V -1 09/04/20, 11:28 Completed build in 11m 11s on Fri, 4 Sep, 11:28 AM Test Summary: 180 of 73685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5231

  5. Benni Mack uploaded patch set 6 09/05/20, 07:13

  6. TYPO3com voted on patch set 6 V -1 09/05/20, 07:25 Completed build in 11m 55s on Sat, 5 Sep, 07:25 AM Test Summary: 15 of 73691 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5255

  7. Benni Mack uploaded patch set 7 09/05/20, 07:34

  8. TYPO3com voted on patch set 7 V +1 09/05/20, 07:48 Completed build in 13m 19s on Sat, 5 Sep, 07:48 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5257

  9. Benni Mack uploaded patch set 8 09/05/20, 09:50

  10. Andreas Kienast commented on patch set 8 09/05/20, 10:16

    CommandMap.php:256

    Do we still need this?

    DataHandlerHook.php:107

    Also still required?

    DataHandlerHook.php:236

    ... and this?

    WorkspaceService.php:146

    Maybe add a remark this argument is unused (bonus: rename to $_ or alike)
  11. Benni Mack commented on patch set 8 09/05/20, 10:17

    CommandMap.php:256 Reply

    Yes. otherwise testing framework won't work with v11 and v10.

    DataHandlerHook.php:107 Reply Unresolved

    Yes. otherwise testing framework won't work with v11 and v10.

    DataHandlerHook.php:236 Reply Unresolved

    Yes. otherwise testing framework won't work with v11 and v10.

    WorkspaceService.php:146 Reply Unresolved

    good point
  12. Andreas Kienast commented on patch set 8 09/05/20, 10:19

    CommandMap.php:256 Reply

    Ack
  13. Benni Mack uploaded patch set 9 09/05/20, 10:19

  14. TYPO3com voted on patch set 9 V -1 09/05/20, 10:20 Completed build in 30s on Sat, 5 Sep, 10:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5267

  15. TYPO3com voted on patch set 8 V +1 09/05/20, 10:20 Completed build in 22m 05s on Sat, 5 Sep, 10:20 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5264

  16. Anja Leichsenring uploaded patch set 10 09/05/20, 10:27

  17. Oliver Hader commented on patch set 10 09/05/20, 10:40

    Nice one... it feels that those parts introducing new "publish" action (which did not exist before) should get a comment why it was inserted and that "swap" stays there for compat reasons... I'll have a closer look into the implementation next week (if it's not merged until then)
  18. TYPO3com voted on patch set 10 V +1 09/05/20, 10:41 Completed build in 13m 42s on Sat, 5 Sep, 10:41 AM Test Summary: 73205 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5268

  19. Andreas Kienast commented on patch set 10 V +1 CR +1 09/05/20, 10:45

    Works for me as far as I tested the patch. I opt to let Olly have a closer look.
  20. Oliver Klee commented on patch set 10 09/05/20, 10:54

    DataHandlerHook.php:107

    Should we mark this value as deprecated?
  21. Benni Mack commented on patch set 10 09/05/20, 11:21

    DataHandlerHook.php:107 Reply Unresolved

    thought about it as well. In general we should rename "swap" with "publish" everywhere (as a separate patch), but this one is kept to allow testing framework use "swap" without deprecations.
  22. Christian Kuhn voted on patch set 10 V +1 CR +1 09/05/20, 11:23

  23. Christian Kuhn commented on patch set 10 09/05/20, 11:28

    > Nice one... it feels that those parts introducing new "publish" action (which did not exist before) should get a comment why it was inserted and that "swap" stays there for compat reasons... > I'll have a closer look into the implementation next week (if it's not merged until then) That's a bit dirty with current patch since we need a bit more cleanups in DataHandler and testing-framework to finalize this. I guess that will happen, soon.
  24. Benni Mack commented on patch set 10 V +2 CR +2 09/05/20, 11:34

    Thank you for this change!
  25. Benni Mack merged patch set 11 09/05/20, 11:34