65318[!!!][TASK] Remove support for swapping instead of publishing workspace records
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 29
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts+10 −16
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+0 −19
- typo3/sysext/core/Classes/Versioning/VersionState.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92206-RemoveWorkspaceSwappingOfElements.rstnew+53 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+0 −3
- typo3/sysext/frontend/Classes/Hooks/TreelistCacheUpdateHooks.php+3 −3
- typo3/sysext/workspaces/Classes/Command/AutoPublishCommand.php+2 −7
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+13 −17
- typo3/sysext/workspaces/Classes/Controller/Remote/MassActionHandler.php+3 −7
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php3+1 −4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php6+26 −58
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+4 −4
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php2+8 −8
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php+1 −14
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+6 −21
- typo3/sysext/workspaces/Resources/Private/Language/locallang_db.xlf+0 −12
- typo3/sysext/workspaces/Resources/Private/Language/locallang_mod_user_ws.xlf+0 −3
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/DataSet/LiveDefaultElements.csv+35 −35
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/DataSet/LiveDefaultElements.csv+1 −1
Show 9 more files
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/DataSet/LiveDefaultElements.csv+35 −35
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/DataSet/LiveDefaultElements.csv+36 −36
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/DataSet/LiveDefaultElements.csv+27 −27
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/DataSet/LiveDefaultElements.csv+3 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/DataSet/LiveDefaultElements.csv+21 −21
- typo3/sysext/workspaces/Tests/Functional/Hook/DataSet/deletingSysWorkspaceDeletesWorkspaceRecords.csv+20 −20
- typo3/sysext/workspaces/Tests/Functional/Hook/DataSet/deletingSysWorkspaceDeletesWorkspaceRecordsResult.csv+21 −21
- typo3/sysext/workspaces/Tests/Functional/Tca/WorkspaceVisibleFieldsTest.php+0 −1
- typo3/sysext/workspaces/ext_tables.sql+0 −1
Review log 2131
Show 36 earlier messages
-
Benni Mack uploaded patch set 1 08/13/20, 11:50
-
TYPO3com voted on patch set 1 V -1 08/13/20, 12:06 Completed build in 13m 09s on Thu, 13 Aug, 12:06 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4618
-
Benni Mack uploaded patch set 2 08/13/20, 12:22
-
TYPO3com voted on patch set 2 V +1 08/13/20, 12:34 Completed build in 11m 06s on Thu, 13 Aug, 12:34 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4621
-
Benni Mack uploaded patch set 3 08/31/20, 20:16
-
TYPO3com voted on patch set 3 V +1 08/31/20, 20:32 Completed build in 16m 02s on Mon, 31 Aug, 08:32 PM Test Summary: 73145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5092
-
Benni Mack uploaded patch set 4 09/04/20, 09:41
-
TYPO3com voted on patch set 4 V +1 09/04/20, 09:54 Completed build in 12m 32s on Fri, 4 Sep, 09:54 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5224
-
Benni Mack uploaded patch set 5 09/04/20, 11:17
-
TYPO3com voted on patch set 5 V -1 09/04/20, 11:28 Completed build in 11m 11s on Fri, 4 Sep, 11:28 AM Test Summary: 180 of 73685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5231
-
Benni Mack uploaded patch set 6 09/05/20, 07:13
-
TYPO3com voted on patch set 6 V -1 09/05/20, 07:25 Completed build in 11m 55s on Sat, 5 Sep, 07:25 AM Test Summary: 15 of 73691 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5255
-
Benni Mack uploaded patch set 7 09/05/20, 07:34
-
TYPO3com voted on patch set 7 V +1 09/05/20, 07:48 Completed build in 13m 19s on Sat, 5 Sep, 07:48 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5257
-
Benni Mack uploaded patch set 8 09/05/20, 09:50
-
Andreas Kienast commented on patch set 8 09/05/20, 10:16
DataHandlerHook.php:107Also still required?DataHandlerHook.php:236... and this?WorkspaceService.php:146Maybe add a remark this argument is unused (bonus: rename to $_ or alike) -
Benni Mack commented on patch set 8 09/05/20, 10:17
CommandMap.php:256ReplyYes. otherwise testing framework won't work with v11 and v10.DataHandlerHook.php:107Reply UnresolvedYes. otherwise testing framework won't work with v11 and v10.DataHandlerHook.php:236Reply UnresolvedYes. otherwise testing framework won't work with v11 and v10.WorkspaceService.php:146Reply Unresolvedgood point -
Andreas Kienast commented on patch set 8 09/05/20, 10:19
CommandMap.php:256ReplyAck -
Benni Mack uploaded patch set 9 09/05/20, 10:19
-
TYPO3com voted on patch set 9 V -1 09/05/20, 10:20 Completed build in 30s on Sat, 5 Sep, 10:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5267
-
TYPO3com voted on patch set 8 V +1 09/05/20, 10:20 Completed build in 22m 05s on Sat, 5 Sep, 10:20 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5264
-
Anja Leichsenring uploaded patch set 10 09/05/20, 10:27
-
Oliver Hader commented on patch set 10 09/05/20, 10:40
Nice one... it feels that those parts introducing new "publish" action (which did not exist before) should get a comment why it was inserted and that "swap" stays there for compat reasons... I'll have a closer look into the implementation next week (if it's not merged until then) -
TYPO3com voted on patch set 10 V +1 09/05/20, 10:41 Completed build in 13m 42s on Sat, 5 Sep, 10:41 AM Test Summary: 73205 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5268
-
Andreas Kienast commented on patch set 10 V +1 CR +1 09/05/20, 10:45
Works for me as far as I tested the patch. I opt to let Olly have a closer look. -
Oliver Klee commented on patch set 10 09/05/20, 10:54
DataHandlerHook.php:107Should we mark this value as deprecated? -
Benni Mack commented on patch set 10 09/05/20, 11:21
DataHandlerHook.php:107Reply Unresolvedthought about it as well. In general we should rename "swap" with "publish" everywhere (as a separate patch), but this one is kept to allow testing framework use "swap" without deprecations. -
Christian Kuhn voted on patch set 10 V +1 CR +1 09/05/20, 11:23
-
Christian Kuhn commented on patch set 10 09/05/20, 11:28
> Nice one... it feels that those parts introducing new "publish" action (which did not exist before) should get a comment why it was inserted and that "swap" stays there for compat reasons... > I'll have a closer look into the implementation next week (if it's not merged until then) That's a bit dirty with current patch since we need a bit more cleanups in DataHandler and testing-framework to finalize this. I guess that will happen, soon. -
Benni Mack commented on patch set 10 V +2 CR +2 09/05/20, 11:34
Thank you for this change! -
Benni Mack merged patch set 11 09/05/20, 11:34
CommandMap.php:256