Review main Merged

65320[TASK] Add html linting to runTests.sh

Christian Kuhn CR +2 V +2 Easy +25 −0 updated 08/14/20, 15:14

Commit message

The patch for issue #88180 added basic HTML linting
via grunt to the test suite. The patch adds 'grunt lintspaces'
to runTests.sh to easily execute the test locally, too.

Build/Scripts/runTests.sh -s lintHtml

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Windloff +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Windloff +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 08/13/20, 13:35

  2. TYPO3com voted on patch set 1 V +1 08/13/20, 13:47 Completed build in 12m 02s on Thu, 13 Aug, 01:47 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4631

  3. Daniel Windloff commented on patch set 1 V +1 CR +1 08/14/20, 14:41

    Tested with an indentation of 15.
  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/14/20, 15:14

  5. Andreas Kienast merged patch set 2 08/14/20, 15:14