Review main Abandoned

65321[BUGFIX] Bypass webmount check in pagetree lookup

Benjamin Serfhos CR 0 V 0 Easy +10 −7 updated 07/04/23, 14:43

Commit message

This causes the already processed webmount page to query to full row
again for all available items in the array. Which lead to a massive
 query overload.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1214

  1. Benjamin Serfhos uploaded patch set 1 08/13/20, 13:56

  2. Mathias Brodala commented on patch set 1 08/13/20, 14:02

    BackendUserAuthentication.php:363 Unresolved

    Tiny nitpick: this should be $checkWebMount
  3. TYPO3com voted on patch set 1 V -1 08/13/20, 14:07 Completed build in 11m 15s on Thu, 13 Aug, 02:07 PM Test Summary: 72985 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4634

  4. Benjamin Serfhos uploaded patch set 2 08/13/20, 14:13

  5. TYPO3com voted on patch set 2 V +1 08/13/20, 14:27 Completed build in 13m 47s on Thu, 13 Aug, 02:27 PM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4636

  6. Benni Mack commented on patch set 2 06/14/21, 11:16

    Hey Benjamin, do we still need this change, or have the other fixes solved your issue already?
  7. Benjamin Serfhos commented on patch set 2 06/14/21, 12:52

    Reply

    The menu is already optimized in the backend so not really 'required' however looking at the changes it could be a good optimization. I cannot reproduce it locally as this is way to old for me. Sorry :(
  8. Benni Mack updated the commit message in patch set 3 11/18/21, 10:38

  9. Benni Mack wrote 11/29/21, 10:17

    Change destination moved from master to main
  10. Benni Mack updated the commit message in patch set 4 11/29/21, 14:08

  11. Benni Mack wrote 12/10/21, 11:48

    Removed cc Benni Mack.
  12. Benni Mack commented on patch set 4 04/14/23, 16:57

    Can you rebase this change? Otherwise I'd abandon it (can be restored later again) as it hasn't been verified for the past 14 months.
  13. Benni Mack updated the commit message in patch set 5 05/03/23, 09:46

  14. Benjamin Serfhos abandoned the change 07/04/23, 14:43

    Too old to actually verify for new TYPO3 12 version