Review 9.5 Merged

65323[BUGFIX] Extract width and height meta data for all image files

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 08/14/20, 12:38

Commit message

Instead of looking at the mime type of the file, the configured
image file extensions is checked to decide whether to extract
width and height for sys_file_metadata.

This allows pdf files to have their width and height to be extracted.

While the exact pixel values do not matter much for a PDF,
the ratio of width and height (landscape or portrait or even square)
can be very useful to "know".

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Helmut Hummel uploaded patch set 1 08/14/20, 09:23

  2. Helmut Hummel voted on patch set 1 V +2 CR +2 08/14/20, 09:26

  3. TYPO3com voted on patch set 1 V +1 08/14/20, 09:35 Completed build in 12m 05s on Fri, 14 Aug, 09:35 AM Test Summary: 75130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-758

  4. Helmut Hummel merged patch set 2 08/14/20, 12:38