Review main Merged

65324[BUGFIX] Use proper workspace record in stage notifications

Benni Mack CR +2 V +2 Easy +1 −1 updated 08/18/20, 19:05

Commit message

The array key 'shared' already contains the full workspace
record from $BE_USER->checkWorkspace(), so it is not needed
to actually fetch the record (which previously always returned the
workspace with ID 1).

The change removes a superfluous call to fetch the actual
sys_workspace database record.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • mhuber20 +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 08/14/20, 11:19

  2. mhuber20 commented on patch set 1 V +1 08/14/20, 11:32

    succesfully tested - now email contains correct workspace's details
  3. TYPO3com voted on patch set 1 V +1 08/14/20, 11:32 Completed build in 12m 46s on Fri, 14 Aug, 11:32 AM Test Summary: 72986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4657

  4. Oliver Klee voted on patch set 1 CR +1 08/14/20, 12:19

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 08/18/20, 17:57

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/18/20, 19:05

  7. Anja Leichsenring merged patch set 2 08/18/20, 19:05