Review 10.4 Merged

65326[BUGFIX] Correctly call BackendUtility::selectVersionsOfRecord

Oliver Hader CR +2 V +2 Easy +1 −1 updated 08/31/20, 12:03

Commit message

Issue #69135 fixed issue #60249, but introduced an invalid call
to `BackendUtility::selectVersionsOfRecord`. The scope was to
handle all versions in all workspaces (`$workspace=null`).
As a result, without patch, command 'cleanup:versions' reports
too many unused placeholder rows and the action command
'cleanup:versions --action=unused_placeholders' deletes too many.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 710

  1. Oliver Hader uploaded patch set 1 08/14/20, 14:43

  2. TYPO3com voted on patch set 1 V +1 08/14/20, 14:56 Completed build in 12m 55s on Fri, 14 Aug, 02:56 PM Test Summary: 74024 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-212

  3. Alexander Schnitzler voted on patch set 1 V +1 CR +1 08/15/20, 07:54

  4. Christian Kuhn updated the commit message in patch set 2 08/31/20, 11:17

  5. TYPO3com voted on patch set 2 V -1 08/31/20, 11:30 Completed build in 12m 54s on Mon, 31 Aug, 11:30 AM Test Summary: 1 of 74601 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-299

  6. Oliver Hader commented on patch set 2 08/31/20, 11:50

    This change is ready for review.
  7. TYPO3com voted on patch set 2 V +1 08/31/20, 11:51 Completed build in 46m 40s on Mon, 31 Aug, 11:51 AM Test Summary: 74115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-299

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 08/31/20, 11:55

  9. Benni Mack voted on patch set 2 V +2 CR +2 08/31/20, 12:03

  10. Benni Mack merged patch set 3 08/31/20, 12:03