Review main Merged

65328[BUGFIX] Scan for AbstractController, not its methods

Christian Kuhn CR +2 V +2 Normal +0 −96 updated 08/15/20, 13:42

Commit message

With #89554 the extbase MVC class AbstractController has been
deprecated. All methods have been moved to ActionController.
Install tool extension scanner rules have been set up for both
class usage and its methods. This leads to false positives
when calling a parent method in extension classes that extend
ActionController. It is enough to just scan for usages of
AbstractControler classes to find affected extensions with
a strong match for this deprecation.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Björn Jacob +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 811

  1. Christian Kuhn uploaded patch set 1 08/14/20, 17:25

  2. TYPO3com voted on patch set 1 V +1 08/14/20, 17:37 Completed build in 11m 15s on Fri, 14 Aug, 05:37 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4663

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/14/20, 17:44

  4. Andreas Kienast rebased onto patch set 2 08/14/20, 18:19

  5. Björn Jacob updated the commit message in patch set 3 08/14/20, 18:24

  6. Björn Jacob commented on patch set 3 CR +1 08/14/20, 18:25

    Fixed a typo.
  7. TYPO3com voted on patch set 2 V +1 08/14/20, 18:31 Completed build in 12m 07s on Fri, 14 Aug, 06:31 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4665

  8. TYPO3com voted on patch set 3 V +1 08/14/20, 18:35 Completed build in 11m 32s on Fri, 14 Aug, 06:35 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4667

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 08/14/20, 21:20

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/15/20, 13:42

  11. Anja Leichsenring merged patch set 4 08/15/20, 13:42