Review main Abandoned

65329[FEATURE] Make LiveSearch in backend extensible via search providers

Andreas Kienast CR 0 V 0 Hard +310 −142 updated 11/09/21, 21:50

Commit message

The LiveSearch backend is refactored to be able to add custom search
providers to be able to search entities not being database records.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 1728

Show 23 earlier messages
  1. Andreas Kienast uploaded patch set 1 08/14/20, 17:38

  2. TYPO3com voted on patch set 1 V -1 08/14/20, 17:39 Completed build in 26s on Fri, 14 Aug, 05:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4664

  3. Andreas Kienast uploaded patch set 2 08/14/20, 18:19

  1. TYPO3com voted on patch set 2 V -1 08/14/20, 18:19 Completed build in 23s on Fri, 14 Aug, 06:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4666

  2. Andreas Kienast uploaded patch set 3 08/14/20, 22:51

  3. TYPO3com voted on patch set 3 V -1 08/14/20, 22:51 Completed build in 33s on Fri, 14 Aug, 10:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4669

  4. Andreas Kienast uploaded patch set 4 08/14/20, 22:53

  5. Andreas Kienast updated the commit message in patch set 5 08/14/20, 22:55

  6. TYPO3com voted on patch set 4 V +1 08/14/20, 23:05 Completed build in 12m 08s on Fri, 14 Aug, 11:05 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4671

  7. TYPO3com voted on patch set 5 V +1 08/14/20, 23:09 Completed build in 13m 52s on Fri, 14 Aug, 11:09 PM Test Summary: 72982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4672

  8. Daniel Windloff commented on patch set 5 08/15/20, 08:44

    LiveSearchController.php:52 Unresolved

    I would suggest an other solution here: Add an event e.g. LiveSearchColletResultsEvent with - public function __construct(string $queryString) - public function getQueryString(): string - public function addResultItem(ResultItem $resultItem):void - public function getResultItems() : array (returns ResultItem[]). The default provider could be the RecordSearchProvider and the ModuleSearchProvider. The advantages are: - no need for additional GeneralUtility::makeInstance($config['provider']) - the events could be sorted by default (no additional dependencyOrderingService needed) - no need for the SearchProviderInterface and the ResultCollection - no check against !$item instanceof ResultItem needed - less global php config (['SYS']['livesearch'])
  9. Daniel Windloff commented on patch set 5 08/15/20, 09:08

    On it
  10. Daniel Windloff uploaded patch set 6 08/15/20, 09:43

  11. Daniel Windloff uploaded patch set 7 08/15/20, 09:47

  12. TYPO3com voted on patch set 6 V +1 08/15/20, 09:55 Completed build in 11m 48s on Sat, 15 Aug, 09:55 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4686

  13. TYPO3com voted on patch set 7 V +1 08/15/20, 09:58 Completed build in 11m 13s on Sat, 15 Aug, 09:58 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4687

  14. Daniel Windloff commented on patch set 7 08/15/20, 10:47

    The "Show All" button also needs a different solution. With new providers the result set is not identical anymore.
  15. Andreas Kienast uploaded patch set 8 08/15/20, 10:55

  16. Andreas Kienast uploaded patch set 9 08/15/20, 10:58

  17. TYPO3com voted on patch set 8 V +1 08/15/20, 11:06 Completed build in 11m 13s on Sat, 15 Aug, 11:06 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4688

  18. TYPO3com voted on patch set 9 V +1 08/15/20, 11:11 Completed build in 12m 24s on Sat, 15 Aug, 11:11 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4690

  19. Andreas Kienast uploaded patch set 10 08/15/20, 17:07

  20. TYPO3com voted on patch set 10 V +1 08/15/20, 17:27 Completed build in 19m 07s on Sat, 15 Aug, 05:27 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4702

  21. Daniel Goerz uploaded patch set 11 10/10/20, 09:04

  22. TYPO3com voted on patch set 11 V +1 10/10/20, 09:17 Completed build in 12m 17s on Sat, 10 Oct, 09:17 AM Test Summary: 73734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6423

  23. Jörg Bösche voted on patch set 11 CR +1 12/17/20, 19:42

  24. Christian Kuhn commented on patch set 11 11/09/21, 21:50

    Andy. Hurt me plenty, but I'm going to abandon this change for now - nothing happened here for quite a while. While the issue is still valid, we may want to align on a general strategy regarding LiveSearch anyway beforehand. While this change well be dropped for now, it can of course always be picked up again when work continues.
  25. Christian Kuhn abandoned the change 11/09/21, 21:50