Review main Merged

65331[BUGFIX] Wrap operands in parentheses

Andreas Kienast CR +2 V +2 Easy +11 −11 updated 08/26/20, 18:07

Commit message

This patch wraps operands in parentheses which could otherwise cause
unwanted side-effects. In most cases null coalesce operators are
affected.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 811

  1. Andreas Kienast uploaded patch set 1 08/14/20, 23:41

  2. Andreas Kienast uploaded patch set 2 08/14/20, 23:42

  3. TYPO3com voted on patch set 1 V +1 08/14/20, 23:55 Completed build in 13m 54s on Fri, 14 Aug, 11:55 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4673

  4. TYPO3com voted on patch set 2 V -1 08/14/20, 23:58 Completed build in 15m 30s on Fri, 14 Aug, 11:58 PM Test Summary: 3 of 73461 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4674

  5. Andreas Kienast uploaded patch set 3 08/26/20, 11:18

  6. TYPO3com voted on patch set 3 V +1 08/26/20, 11:29 Completed build in 11m 11s on Wed, 26 Aug, 11:29 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4975

  7. Jörg Bösche voted on patch set 3 V +1 CR +1 08/26/20, 12:30

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/26/20, 13:36

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 08/26/20, 13:36

  10. Andreas Kienast merged patch set 4 08/26/20, 13:36

  11. Oliver Hader voted on patch set 4 CR +1 08/26/20, 18:07