Review main Abandoned

65334[FEATURE] Add Category Data Processor

Stefan Froemken CR 0 V 0 Hard +391 −0 updated 11/09/21, 22:13

Commit message

Add new Category DataProcessor to fetch
categories of sys_category table within
FLUIDTEMPLATE Content Object.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1015

  1. Stefan Froemken uploaded patch set 1 08/15/20, 07:50

  2. TYPO3com voted on patch set 1 V -1 08/15/20, 07:51 Completed build in 21s on Sat, 15 Aug, 07:51 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4681

  3. Andreas Kienast commented on patch set 1 08/15/20, 08:41

  4. Stefan Froemken uploaded patch set 2 08/15/20, 08:47

  5. TYPO3com voted on patch set 2 V -1 08/15/20, 08:48 Completed build in 27s on Sat, 15 Aug, 08:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4682

  6. Stefan Froemken uploaded patch set 3 08/15/20, 08:50

  7. TYPO3com commented on patch set 3 08/15/20, 08:51 Completed build in 22s on Sat, 15 Aug, 08:51 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4683

  8. Stefan Froemken uploaded patch set 4 08/15/20, 08:54

  9. TYPO3com voted on patch set 4 V -1 08/15/20, 08:55 Completed build in 21s on Sat, 15 Aug, 08:55 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4684

  10. Stefan Froemken commented on patch set 3 08/15/20, 08:58

    > Patch Set 1: > > Isn't this basically the same as https://review.typo3.org/c/Packages/TYPO3.CMS/+/62123? Nearly. With my patch you get all categories of a record. Within fluid you can loop over them nicely with f:for without looking for any recursions. So, it's easy to build a comma separated list of category titles. The other patch respects the category tree. A f:for just loops over the first level of the tree and the integrator has to check for each entry, if subCategories is filled and loop them too. Perfect to build your own category tree in frontend.
  11. Stefan Froemken uploaded patch set 5 08/15/20, 08:58

  12. TYPO3com voted on patch set 5 V +1 08/15/20, 09:10 Completed build in 10m 59s on Sat, 15 Aug, 09:10 AM Test Summary: 72995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4685

  13. Christian Kuhn commented on patch set 5 CR -1 08/15/20, 11:33

    -1 for now: it needs to be verified this solution works well with workspaces. functional tests should show this is the case.

    CategoryProcessor.php:78 Unresolved

    With the DatabaseQueryProcessor we have a similar processor that creates queries from TypoScript settings. This one has major issues with workspace overlays, see my comment on https://forge.typo3.org/issues/85284 as an example. Since sys_category is workspace aware, too, we should try to not repeat the problems we've introduced with the DatabaseQueryProcessor. So, we at leas need a solid set of test cases to verify the solution works well with workspace overlays.
  14. Christian Kuhn commented on patch set 5 11/09/21, 22:13

    Hey. This idea sounds legit. We however have to take care of workspaces here and DataProcessors already have too many issues in this regard, so we shouldn't introduce new issues in this are. I'd be fine with the change if additional tests verify workspace behavior. Since nothing happened on this feature for quite a while, I hope it is ok to abondon the patch for now, tough. It could probably live in an extension for now and a core solution should come up with proper coverage. The change can always be resurrected if work continues, of course.
  15. Christian Kuhn abandoned the change 11/09/21, 22:13