Review 10.4 Merged

65335[BUGFIX] Add polyfill for custom elements

Andreas Kienast CR +2 V +2 Easy +18 −1 updated 08/17/20, 12:37

Commit message

The patch merged with #91191 creates a custom HTML element by using
`document.createElement()`. This feature is not supported by traditional
Edge and needs to be polyfilled.

This patch imports the `document-register-element` polyfill into
`ImmediateActionElement`, where this feature is used.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 2

Files 6

Review log 67

  1. Andreas Kienast uploaded patch set 1 08/15/20, 08:37

  2. Richard Haeser voted on patch set 1 V +1 CR +1 08/15/20, 08:47

  3. TYPO3com voted on patch set 1 V +1 08/15/20, 08:49 Completed build in 12m 12s on Sat, 15 Aug, 08:49 AM Test Summary: 74021 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-215

  4. Daniel Haupt voted on patch set 1 CR +1 08/16/20, 10:58

  5. Richard Haeser commented on patch set 1 08/17/20, 12:37

    Also verified by Fabian König in https://forge.typo3.org/issues/91896#change-429320
  6. Richard Haeser voted on patch set 1 V +2 CR +2 08/17/20, 12:37

  7. Richard Haeser merged patch set 2 08/17/20, 12:37