Review main Merged

65336[TASK] Non-admin users see all workspace tabs

Christian Kuhn CR +2 V +2 Easy +7 −15 updated 08/15/20, 17:06

Commit message

The workspace module has a restriction for non-admin users
to show only the currently selected workspace as tab. This
does not make much sense since all workspaces are listed
in the toolbar, too. With the now decluttered interface
no longer showing 'all workspaces' and 'live workspace'
tabs, the restriction is lifted so all users see all
workspaces as tabs they have access to.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/15/20, 11:54

  2. TYPO3com voted on patch set 1 V +1 08/15/20, 12:05 Completed build in 10m 33s on Sat, 15 Aug, 12:05 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4692

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/15/20, 13:36

  4. Riccardo De Contardi commented on patch set 1 V +1 08/15/20, 14:02

    verified with latest master
  5. Andreas Kienast voted on patch set 1 V +2 CR +2 08/15/20, 17:05

  6. Andreas Kienast merged patch set 2 08/15/20, 17:06