Review main Abandoned

65337[WIP][FEATURE] Implement deferred local frontend image processing

Tim Schreiner CR 0 V 0 Hard +474 −3 updated 03/05/22, 23:31

Commit message

Images are no longer processed during main request. Only processed
file database entry will be written. Unprocessed files with existing
database entry will be processed by a middleware and returned.

The processor uses the final image url to not mess up frontend caching.
To make that work, there needs to some an adjustment in the .htaccess
file. When applying this patch, please make sure to apply the changes
made in root-htaccess to your htaccess.

Some of this changes are based on
https://review.typo3.org/c/Packages/TYPO3.CMS/+/65237
and will be removed once they are merged.

Review

  • Code review CR 0
  • Verified V 0

Files 11

Review log 1217

  1. Tim Schreiner uploaded patch set 1 08/15/20, 12:09

  2. Tim Schreiner updated the commit message in patch set 2 08/15/20, 12:11

  3. Tim Schreiner updated the commit message in patch set 3 08/15/20, 12:11

  4. TYPO3com voted on patch set 1 V -1 08/15/20, 12:21 Completed build in 12m 08s on Sat, 15 Aug, 12:21 PM Test Summary: 51 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4693

  5. TYPO3com voted on patch set 2 V -1 08/15/20, 12:24 Completed build in 13m 06s on Sat, 15 Aug, 12:24 PM Test Summary: 48 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4694

  6. TYPO3com voted on patch set 3 V -1 08/15/20, 12:28 Completed build in 16m 31s on Sat, 15 Aug, 12:28 PM Test Summary: 48 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4695

  7. Tim Schreiner uploaded patch set 4 08/15/20, 19:06

  8. TYPO3com voted on patch set 4 V -1 08/15/20, 19:06 Completed build in 22s on Sat, 15 Aug, 07:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4707

  9. Tim Schreiner uploaded patch set 5 08/15/20, 20:08

  10. TYPO3com voted on patch set 5 V -1 08/15/20, 20:22 Completed build in 14m 18s on Sat, 15 Aug, 08:22 PM Test Summary: 48 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4708

  11. Helmut Hummel commented on patch set 3 08/16/20, 10:25

    DeferredImageController.php:81

    I played around with trying to use this API for deferred backend image processing but in the end I came to the conclusion, that it won't work out when processing the same image with the same configuration multiple times during one request, when the result of the processing is that the original file should be used. then one processes will set the identifier and name to an empty string and this API call in a second process will not find it any more. While this is an edge case, this case will break hard. So we need to put some thoughts into how we can circumvent this issue.
  12. Tim Schreiner commented on patch set 5 08/16/20, 15:34

    DeferredImageController.php:81 Reply Unresolved

    Thanks for this hint. Parallel processing of same images with the same configuration on the same page is still a case I need to test. There might be also the case, that one request can not write the processed image file because it is written by another process in the same time. Especially for larger images on hardware with low IO (HDD) can this be a case. I'm also not really happy with this solution. I don't know if this solution works, if TYPO3 runs inside a subdirectory. Will also test your case and put some thoughts into it.
  13. Jochen Roth commented on patch set 5 11/03/21, 11:23

    @tim are you still working on this? If not, could you please abandon this patch. The other/related patch was already merged.
  14. Benni Mack wrote 11/29/21, 10:15

    Change destination moved from master to main
  15. Benni Mack updated the commit message in patch set 6 11/29/21, 14:03

  16. Christian Kuhn commented on patch set 6 03/05/22, 23:31

    Hey. I hope it's ok to abandon this patch for now. In case work continues, it could be resurrected or pushed as a fresh approach.
  17. Christian Kuhn abandoned the change 03/05/22, 23:31