65337[WIP][FEATURE] Implement deferred local frontend image processing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 11
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php+20 −0
- typo3/sysext/core/Classes/Imaging/ImageDimension.phpnew+160 −0
- typo3/sysext/core/Classes/Resource/Processing/DeferredLocalFrontendImageProcessor.phpnew+65 −0
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php+3 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php+6 −0
- typo3/sysext/frontend/Classes/Controller/Exception/DeferredFileProcessingException.phpnew+24 −0
- typo3/sysext/frontend/Classes/Controller/Exception/ProcessedFileNotFoundException.phpnew+24 −0
- typo3/sysext/frontend/Classes/Controller/DeferredImageController.php2new+113 −0
- typo3/sysext/frontend/Classes/Middleware/DeferredLocalFrontendImageProcessing.phpnew+43 −0
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+9 −0
- typo3/sysext/install/Resources/Private/FolderStructureTemplateFiles/root-htaccess+7 −1
Review log 1217
-
Tim Schreiner uploaded patch set 1 08/15/20, 12:09
-
Tim Schreiner updated the commit message in patch set 2 08/15/20, 12:11
-
Tim Schreiner updated the commit message in patch set 3 08/15/20, 12:11
-
TYPO3com voted on patch set 1 V -1 08/15/20, 12:21 Completed build in 12m 08s on Sat, 15 Aug, 12:21 PM Test Summary: 51 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4693
-
TYPO3com voted on patch set 2 V -1 08/15/20, 12:24 Completed build in 13m 06s on Sat, 15 Aug, 12:24 PM Test Summary: 48 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4694
-
TYPO3com voted on patch set 3 V -1 08/15/20, 12:28 Completed build in 16m 31s on Sat, 15 Aug, 12:28 PM Test Summary: 48 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4695
-
Tim Schreiner uploaded patch set 4 08/15/20, 19:06
-
TYPO3com voted on patch set 4 V -1 08/15/20, 19:06 Completed build in 22s on Sat, 15 Aug, 07:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4707
-
Tim Schreiner uploaded patch set 5 08/15/20, 20:08
-
TYPO3com voted on patch set 5 V -1 08/15/20, 20:22 Completed build in 14m 18s on Sat, 15 Aug, 08:22 PM Test Summary: 48 of 73467 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4708
-
Helmut Hummel commented on patch set 3 08/16/20, 10:25
-
Tim Schreiner commented on patch set 5 08/16/20, 15:34
DeferredImageController.php:81Reply UnresolvedThanks for this hint. Parallel processing of same images with the same configuration on the same page is still a case I need to test. There might be also the case, that one request can not write the processed image file because it is written by another process in the same time. Especially for larger images on hardware with low IO (HDD) can this be a case. I'm also not really happy with this solution. I don't know if this solution works, if TYPO3 runs inside a subdirectory. Will also test your case and put some thoughts into it. -
Jochen Roth commented on patch set 5 11/03/21, 11:23
@tim are you still working on this? If not, could you please abandon this patch. The other/related patch was already merged. -
Benni Mack wrote 11/29/21, 10:15
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 6 11/29/21, 14:03
-
Christian Kuhn commented on patch set 6 03/05/22, 23:31
Hey. I hope it's ok to abandon this patch for now. In case work continues, it could be resurrected or pushed as a fresh approach. -
Christian Kuhn abandoned the change 03/05/22, 23:31
DeferredImageController.php:81