Review main Merged

65339[TASK] Extract SVG image processing into processor

Helmut Hummel CR +2 V +2 Hard +518 −111 updated 08/22/20, 11:48

Commit message

Instead of spreading (similar) code that handles SVG
files in multiple classes with conditional code
branching, processing SVG files (mostly calculating
new width and height according to the configuration)
is now placed in an own file processor.

Cropping SVGs is still done like before using IM/GM
and resulting in an png image. In this case the new
processor is skipped and the file is passed to the
existing LocalImageProcessor.

A new class is introduced, which calculates resulting
image dimension from an original dimension and a given
processing task.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Tim Schreiner +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1722

  1. Helmut Hummel uploaded patch set 1 08/15/20, 17:07

  2. Helmut Hummel wrote 08/15/20, 17:08

    Topic set to image-processing
  3. TYPO3com voted on patch set 1 V +1 08/15/20, 17:22 Completed build in 14m 47s on Sat, 15 Aug, 05:22 PM Test Summary: 73061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4701

  4. Oliver Klee commented on patch set 1 08/15/20, 17:25

    SvgImageProcessor.php:2

    strict, please.
  5. Andreas Kienast uploaded patch set 2 08/15/20, 20:42

  6. Andreas Kienast voted on patch set 2 CR +1 08/15/20, 20:44

  7. TYPO3com voted on patch set 2 V +1 08/15/20, 20:54 Completed build in 11m 43s on Sat, 15 Aug, 08:54 PM Test Summary: 73061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4712

  8. Oliver Klee wrote 08/16/20, 10:40

    Removed reviewer Oliver Klee.
  9. Helmut Hummel uploaded patch set 3 08/16/20, 16:06

  10. Helmut Hummel commented on patch set 3 08/16/20, 16:14

    SvgImageProcessor.php:2 Reply

    Ack
  11. TYPO3com commented on patch set 3 08/16/20, 16:19 Completed build in 11m 56s on Sun, 16 Aug, 04:19 PM Test Summary: 73061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4720

  12. Tim Schreiner commented on patch set 3 08/17/20, 21:05

    ImageDimension.php:97

    I think $cropHeight should be used here for second compare statement.

    ImageDimension.php:105

    This should be cast to int

    ImageDimension.php:107

    This should be cast to int
  13. Tim Schreiner uploaded patch set 4 08/17/20, 21:08

  14. Tim Schreiner commented on patch set 4 CR +1 08/17/20, 21:10

    ImageDimension.php:97 Reply

    Done

    ImageDimension.php:105 Reply

    Done

    ImageDimension.php:107 Reply

    Done
  15. TYPO3com voted on patch set 4 V +1 08/17/20, 21:21 Completed build in 12m 41s on Mon, 17 Aug, 09:21 PM Test Summary: 73076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4746

  16. Tim Schreiner uploaded patch set 5 08/18/20, 06:39

  17. TYPO3com voted on patch set 5 V +1 08/18/20, 06:52 Completed build in 12m 01s on Tue, 18 Aug, 06:52 AM Test Summary: 73076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4750

  18. Tim Schreiner voted on patch set 5 CR +1 08/18/20, 07:55

  19. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/22/20, 11:29

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 08/22/20, 11:47

  21. Helmut Hummel voted on patch set 5 V +2 CR +2 08/22/20, 11:47

  22. Helmut Hummel merged patch set 6 08/22/20, 11:48