65339[TASK] Extract SVG image processing into processor
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Anja Leichsenring +1
- Tim Schreiner +1
- Christian Kuhn +1
-
Verified V +2 Done
- Helmut Hummel +2
- Anja Leichsenring +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php+20 −0
- typo3/sysext/core/Classes/Imaging/ImageDimension.php6new+164 −0
- typo3/sysext/core/Classes/Resource/Processing/AbstractGraphicalTask.php+4 −0
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+10 −60
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php+3 −14
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php+23 −36
- typo3/sysext/core/Classes/Resource/Processing/ProcessorRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/Processing/SvgImageProcessor.php2new+55 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+6 −0
- typo3/sysext/core/Tests/Unit/Imaging/ImageDimensionTest.phpnew+232 −0
Review log 1722
-
Helmut Hummel uploaded patch set 1 08/15/20, 17:07
-
Helmut Hummel wrote 08/15/20, 17:08
Topic set to image-processing -
TYPO3com voted on patch set 1 V +1 08/15/20, 17:22 Completed build in 14m 47s on Sat, 15 Aug, 05:22 PM Test Summary: 73061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4701
-
Oliver Klee commented on patch set 1 08/15/20, 17:25
SvgImageProcessor.php:2strict, please. -
Andreas Kienast uploaded patch set 2 08/15/20, 20:42
-
Andreas Kienast voted on patch set 2 CR +1 08/15/20, 20:44
-
TYPO3com voted on patch set 2 V +1 08/15/20, 20:54 Completed build in 11m 43s on Sat, 15 Aug, 08:54 PM Test Summary: 73061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4712
-
Oliver Klee wrote 08/16/20, 10:40
Removed reviewer Oliver Klee. -
Helmut Hummel uploaded patch set 3 08/16/20, 16:06
-
Helmut Hummel commented on patch set 3 08/16/20, 16:14
SvgImageProcessor.php:2ReplyAck -
TYPO3com commented on patch set 3 08/16/20, 16:19 Completed build in 11m 56s on Sun, 16 Aug, 04:19 PM Test Summary: 73061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4720
-
Tim Schreiner commented on patch set 3 08/17/20, 21:05
ImageDimension.php:97I think $cropHeight should be used here for second compare statement.ImageDimension.php:105This should be cast to intImageDimension.php:107This should be cast to int -
Tim Schreiner uploaded patch set 4 08/17/20, 21:08
-
Tim Schreiner commented on patch set 4 CR +1 08/17/20, 21:10
ImageDimension.php:97ReplyDoneImageDimension.php:105ReplyDoneImageDimension.php:107ReplyDone -
TYPO3com voted on patch set 4 V +1 08/17/20, 21:21 Completed build in 12m 41s on Mon, 17 Aug, 09:21 PM Test Summary: 73076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4746
-
Tim Schreiner uploaded patch set 5 08/18/20, 06:39
-
TYPO3com voted on patch set 5 V +1 08/18/20, 06:52 Completed build in 12m 01s on Tue, 18 Aug, 06:52 AM Test Summary: 73076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4750
-
Tim Schreiner voted on patch set 5 CR +1 08/18/20, 07:55
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 08/22/20, 11:29
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/22/20, 11:47
-
Helmut Hummel voted on patch set 5 V +2 CR +2 08/22/20, 11:47
-
Helmut Hummel merged patch set 6 08/22/20, 11:48