Review main Abandoned

65340[TASK] Only show widgets to add if they are not in the current dashboard

Daniel Windloff CR 0 V 0 Easy +18 −8 updated 04/04/21, 08:23

Commit message

Widgets should provide a simple overview of a status or quick access to
actions.
Therefore, a user (editor) configuration of a widget doesn't make sense
at all. So there is no benefit in adding a widget multiple times to a
single dashboard.

Removing the widgets from the add wizard, that have already been added
to the dashboard, also has the advantage that a user can quickly see
which other widgets he can add.

Therefore, multiple adding of widgets to a dashboard has been removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 45

  1. Daniel Windloff uploaded patch set 1 08/16/20, 05:15

  2. TYPO3com voted on patch set 1 V +1 08/16/20, 05:27 Completed build in 11m 37s on Sun, 16 Aug, 05:27 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4713

  3. Richard Haeser commented on patch set 1 CR -1 08/17/20, 19:06

    There are already some ideas to add user based configuration (for example refresh rate, or specific page tree) and as that was always the idea for the future. That is also why you can have multiple of the same widgets on the same dashboard. Maybe it is good to give visual feedback that this widget is already on the dashboard, but I would not hide them.
  4. Daniel Windloff commented on patch set 1 08/17/20, 20:06

    What about a configuration option for a widget, which controls if it could be added multiple times? If there is no use case for it (and you already know it as dev), I think to hide it is the best option as it can not end into any confusion.
  5. Daniel Windloff abandoned the change 04/04/21, 08:23