Review main Merged

65341[TASK] Dashboard: Adjust toolbar items look

Daniel Windloff CR +2 V +2 Easy +4 −25 updated 05/11/21, 20:18

Commit message

Use the standard layout for toolbar items to make recurring elements
look the same in the various core modules.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1822

  1. Daniel Windloff uploaded patch set 1 08/16/20, 06:37

  2. TYPO3com voted on patch set 1 V +1 08/16/20, 06:49 Completed build in 11m 47s on Sun, 16 Aug, 06:49 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4714

  3. Richard Haeser commented on patch set 1 CR -1 08/17/20, 18:56

    This was done on purpose (by Benjamin Kott and others). The dashboard was styled a little bit different from the rest as this might be a start to "freshen up" some things in the backend. In several ways it is not completely consistent. I can see benefits for this change from an accessibility perspective. On the other hand I do like the styling of the current way. I'm not sure if it is really needed for accessibility as well, so maybe we should discuss this first in #cig-dashboard on Slack?
  4. Daniel Goerz commented on patch set 1 05/04/21, 20:06

    Did you discuss it? Let's merge or abandon then 😊
  5. Christian Kuhn rebased onto patch set 2 05/05/21, 09:27

  6. Christian Kuhn commented on patch set 2 V +1 CR +1 05/05/21, 09:33

    Rebased for now. I not too fond of having some special case here, just because we can. The patch changes the docheader buttons on the right and brings them in-line with the rest of the system again. It seems the experiment of having a little bit different docheader is stalled at the moment, so I think we should streamline this detail for consistency reasons.
  7. Richard Haeser commented on patch set 2 V -1 05/05/21, 09:35

    let me check after my holiday.
  8. core-ci voted on patch set 2 V +1 05/05/21, 09:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11189

  9. Richard Haeser commented on patch set 2 05/10/21, 09:34

    Hmm.. I had a look at it. If you see it as the docheader, you are completely right, but actually I didn't see it as the docheader. It is the background of the tabs you have (if you have multiple dashboards you will see this a bit more clear). And that is a "unique" thing as far as I know which might have a different "view". But I agree that we should have a as unified as possible view in the backend. So I'm ok with changing this a bit. This patch is not completely right though. It will give an extra whitespace below the tabs. Besides that, you can also argue if the other icons shouldn't be converted to buttons as well.
  10. Richard Haeser commented on patch set 2 05/10/21, 09:36

    Reply

    It also have a different hover as "normal" buttons at the moment. So we should unify that as well.
  11. Richard Haeser uploaded patch set 3 05/10/21, 10:06

  12. core-ci voted on patch set 3 V +1 05/10/21, 10:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11333

  13. Richard Haeser voted on patch set 3 V +1 CR +1 05/10/21, 10:20

  14. Richard Haeser commented on patch set 3 05/10/21, 10:22

    I kept the icons for the widgets for now as I'm not sure if that should be buttons. If so, we can make another change for that.
  15. Richard Haeser commented on patch set 3 05/10/21, 10:23

    I also don't think this should be backported to v10 as it is not a bugfix and we shouldn't change too much of UI / UX in a LTS release IMHO.
  16. Benjamin Franzke commented on patch set 3 CR -1 05/10/21, 14:15

    Main.html:16 Unresolved

    We should actually drop the (now) unused dashboard-configuration-button class then.
  17. Richard Haeser uploaded patch set 4 05/11/21, 20:05

  18. Richard Haeser voted on patch set 4 V +1 CR +1 05/11/21, 20:06

  19. Benjamin Franzke voted on patch set 4 CR +1 05/11/21, 20:12

  20. core-ci voted on patch set 4 V +1 05/11/21, 20:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11407

  21. Benjamin Franzke voted on patch set 4 V +2 CR +2 05/11/21, 20:18

  22. Benjamin Franzke merged patch set 5 05/11/21, 20:18