Review main Merged

65342[TASK] Switch to new REST API end point

Simon Gilli CR +2 V +2 Normal +59 −2 updated 12/21/21, 10:19

Commit message

The core version service now uses the new entry point of the REST API
available via https://get.typo3.org/api.

The old entry point is still available but should not be longer used.

For more information see `https://get.typo3.org/api/doc <https://get.typo3.org/api/doc>`_
and `https://github.com/TYPO3/get.typo3.org/pull/272 <https://github.com/TYPO3/get.typo3.org/pull/272>`_.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Susi Moog +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 3136

Show 911 earlier messages
  1. Simon Gilli uploaded patch set 1 08/16/20, 09:02

  2. Simon Gilli marked it work in progress 08/16/20, 09:03

  3. Simon Gilli commented on patch set 1 08/16/20, 09:03

    This change is ready for review.
  4. Simon Gilli marked it work in progress 08/16/20, 09:08

  5. TYPO3com voted on patch set 1 V +1 08/16/20, 09:14 Completed build in 11m 55s on Sun, 16 Aug, 09:14 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4715

  6. Simon Gilli uploaded patch set 2 08/16/20, 09:16

  7. TYPO3com voted on patch set 2 V +1 08/16/20, 09:29 Completed build in 12m 17s on Sun, 16 Aug, 09:29 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4716

  8. Benni Mack wrote 11/29/21, 09:58

    Change destination moved from master to main
  9. Benni Mack updated the commit message in patch set 3 11/29/21, 13:19

  10. Simon Gilli updated the commit message in patch set 4 12/02/21, 19:17

  11. Simon Gilli rebased onto patch set 5 12/02/21, 20:09

  1. core-ci voted on patch set 5 V +1 12/02/21, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20441

  2. Simon Gilli commented on patch set 5 12/12/21, 22:50

    This change is ready for review.
  3. Stefan Bürk commented on patch set 5 V -1 12/12/21, 23:37

    Sry, -1 verification here. Used new url seams not to work. Neither fo the docs nor for api call, old /api/v1/xxx routes are working. For ex. ``` $ curl -X GET "https://get.typo3.org/api/v1/major/11/release/"; -H "accept: application/json" {"type":"https:\/\/tools.ietf.org\/html\/rfc2616#section-10","title":"An error occurred","status":404,"detail":"Not Found"} ```
    Links are not working, at least on my side. Getting 404 on it. https://get.typo3.org/api/doc not reachable, https://get.typo3.org/api/v1/doc is ...
  4. Simon Gilli commented on patch set 5 12/13/21, 08:40

    Reply

    This works here.

    Reply

    Right, the docs link is wrong. The server currently expects the version. Will check....
  5. Stefan Bürk wrote 12/13/21, 09:07

    Removed Verified-1 by Stefan Bürk <stefan@buerk.tech>
  6. Simon Gilli updated the commit message in patch set 6 12/13/21, 09:14

  7. Simon Gilli commented on patch set 6 12/13/21, 09:17

    Reply

    Fixed
  8. Stefan Bürk commented on patch set 6 V +1 CR +1 12/13/21, 09:20

    Was confused with the doc url in the commit message (which did not worked first). New and old endpoints working (if used correctly).

    Reply

    Done
  9. core-ci voted on patch set 6 V +1 12/13/21, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21018

  10. Christian Kuhn voted on patch set 6 CR +1 12/13/21, 11:57

  11. Chris Müller commented on patch set 6 12/13/21, 13:37

    The changelog entry should be moved to 12.0 folder (or maybe 10.4.x?)
  12. Stefan Bürk commented on patch set 6 V 0 CR 0 12/13/21, 13:51

    Reply

    ^ good point
  13. Benni Mack commented on patch set 6 12/14/21, 12:01

    "master" does not exist anymore in the Documentation folder. Either make it "10.4.x" or "12.0" or whatever makes sense in this case. Maybe @Lina has some input on this?
  14. Lina Wolf commented on patch set 6 CR -1 12/15/21, 08:28

    The changelog entry needs to go in 12.0, 11.5.x and 10.4.x, see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/Howto.html#location
  15. Lina Wolf commented on patch set 6 12/15/21, 08:34

    Please also put more information in the Changelog. Missing the impact section, see: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/Howto.html#file-content
  16. Christian Kuhn commented on patch set 6 12/15/21, 11:08

    I'd argue we could leave out the .rst file altogether: Our usage of get.typo3.org is install tool internal and core is only consumer of that api. Communicating end points of get.typo3.org should probably happen elsewhere.
  17. Stefan Bürk commented on patch set 6 12/15/21, 11:21

    Reply

    I would go with the argumentation from Christian. This is an internal change which url to call for the install tool. Would avoid the rst file for that at all.
  18. Stefan Bürk uploaded patch set 7 12/19/21, 20:15

  19. Stefan Bürk commented on patch set 7 V +1 CR +1 12/19/21, 20:24

    Reply

    Done
  20. core-ci voted on patch set 7 V +1 12/19/21, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21261

  21. Susi Moog voted on patch set 7 CR +1 12/21/21, 08:43

  22. Simon Gilli commented on patch set 7 12/21/21, 10:06

    Reply

    The intention was here to make the users aware of the change in case they have to change their security settings concerning outgoing communication to other servers. So please reevaluate with this information.
  23. Christian Kuhn commented on patch set 7 V +1 CR +1 12/21/21, 10:12

    Reply

    ok. fine with me. thx.
  24. Christian Kuhn voted on patch set 7 V +2 CR +2 12/21/21, 10:19

  25. Christian Kuhn merged patch set 8 12/21/21, 10:19