Review main Merged

65346[TASK] Make online media preview processing a processor

Helmut Hummel CR +2 V +2 Hard +99 −213 updated 08/22/20, 12:46

Commit message

Due to the fact that configurable processors weren't present
when online media handling was introduced,
a lot of code needed to be duplicated to make
the processing work in a pre process event.

Since we have configurable processors now,
the code should is moved to a processor
and the code duplication removed.

This change is also a prerequisite to make
deferred image processing work more smoothly,
because the online media preview processing
should be handled after a deferred image processor
but before regular local image processing.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1118

  1. Helmut Hummel uploaded patch set 1 08/16/20, 16:04

  2. TYPO3com voted on patch set 1 V -1 08/16/20, 16:04 Completed build in 21s on Sun, 16 Aug, 04:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4719

  3. Helmut Hummel wrote 08/16/20, 16:04

    Topic set to image-processing
  4. Helmut Hummel rebased onto patch set 2 08/16/20, 16:07

  5. TYPO3com voted on patch set 2 V -1 08/16/20, 16:08 Completed build in 32s on Sun, 16 Aug, 04:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4721

  6. Helmut Hummel rebased onto patch set 3 08/22/20, 11:50

  7. TYPO3com voted on patch set 3 V -1 08/22/20, 12:01 Completed build in 11m 21s on Sat, 22 Aug, 12:01 PM Test Summary: 6 of 40313 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4846

  8. Helmut Hummel uploaded patch set 4 08/22/20, 12:08

  9. Helmut Hummel uploaded patch set 5 08/22/20, 12:14

  10. TYPO3com commented on patch set 4 08/22/20, 12:19 Completed build in 10m 55s on Sat, 22 Aug, 12:19 PM Test Summary: 12 of 73232 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4848

  11. TYPO3com voted on patch set 5 V -1 08/22/20, 12:25 Completed build in 11m 01s on Sat, 22 Aug, 12:25 PM Test Summary: 10 of 63158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4849

  12. Helmut Hummel uploaded patch set 6 08/22/20, 12:31

  13. TYPO3com voted on patch set 6 V -1 08/22/20, 12:42 Completed build in 10m 38s on Sat, 22 Aug, 12:42 PM Test Summary: 72765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4850

  14. TYPO3com voted on patch set 6 V +1 08/22/20, 12:45 Completed build in 24m 30s on Sat, 22 Aug, 12:45 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4850

  15. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/22/20, 12:45

  16. Helmut Hummel voted on patch set 6 V +2 CR +2 08/22/20, 12:46

  17. Christian Kuhn voted on patch set 6 V +1 CR +1 08/22/20, 12:46

  18. Helmut Hummel merged patch set 7 08/22/20, 12:46