Review main Merged

65350[TASK] Add security relevant .htaccess configuration as default

Markus Klein CR +2 V +2 Easy +10 −1 updated 11/15/20, 14:18

Commit message

Since #91354 the Core has security checks for valid and secure HTTP
responses. Add additional configuration in the default .htaccess
template to ensure those checks are green by default.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2023

  1. Markus Klein uploaded patch set 1 08/17/20, 08:46

  2. TYPO3com voted on patch set 1 V +1 08/17/20, 09:00 Completed build in 13m 48s on Mon, 17 Aug, 09:00 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4726

  3. Stefan P commented on patch set 1 08/17/20, 09:17

    root-htaccess:183

    The lines can be merged (same for html above): AddType image/svg+xml .svg .svgz

    root-htaccess:184 Unresolved

    Tabs vs spaces.
  4. Markus Klein commented on patch set 1 08/17/20, 09:24

    root-htaccess:183 Reply Unresolved

    Would be great if you could just use the online editor and fix/change this right away. Will take care
  5. Markus Klein commented on patch set 2 08/17/20, 09:25

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 08/17/20, 09:36 Completed build in 11m 13s on Mon, 17 Aug, 09:36 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4727

  7. Chris topher wrote 08/17/20, 15:06

    Removed reviewer Chris topher.
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 08/18/20, 18:02

  9. Anja Leichsenring commented on patch set 2 08/18/20, 19:20

    I am not completely sure this can be ported, but the core also ships with a sample configuration for nginx (root-web-config in same folder). If nginx needs this information, too, could you please add it here? Thanks.
  10. Markus Klein commented on patch set 2 08/19/20, 07:12

    > Patch Set 2: > > I am not completely sure this can be ported, but the core also ships with a sample configuration for nginx (root-web-config in same folder). > If nginx needs this information, too, could you please add it here? Thanks. I do not have any experience in this regard yet. So I would opt for merging this, as it covers the 99% case. If someone has the rules for nginx at hand too, let add this with a dedicated patch.
  11. Daniel Goerz commented on patch set 2 08/19/20, 18:03

    root-htaccess:177

    Not an apache pro but from reading this coulb bei a oneliner as well like the svg example below?
  12. Anja Leichsenring commented on patch set 2 08/19/20, 18:16

    I am completely fine with merging the patch as is, just wanted to ask the question where the context is clear.
  13. Markus Klein commented on patch set 3 08/19/20, 19:53

    Published edit on patch set 2.
  14. Markus Klein commented on patch set 3 08/19/20, 19:54

    root-htaccess:177 Reply

    Done
  15. TYPO3com voted on patch set 3 V +1 08/19/20, 20:06 Completed build in 12m 03s on Wed, 19 Aug, 08:06 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4774

  16. Daniel Goerz voted on patch set 3 V +1 CR +1 08/20/20, 06:54

  17. Jörg Bösche voted on patch set 3 CR +1 08/20/20, 08:00

  18. Markus Klein commented on patch set 3 V -1 08/20/20, 08:04

    let me check one more thing. will report back
  19. Markus Klein commented on patch set 3 V 0 08/20/20, 08:12

    all good
  20. Christian Kuhn voted on patch set 3 V +1 CR +1 08/21/20, 11:29

  21. Daniel Goerz voted on patch set 3 V +2 CR +2 08/21/20, 11:49

  22. Daniel Goerz merged patch set 4 08/21/20, 11:49

  23. Oliver Hader voted on patch set 4 CR +1 11/15/20, 14:18