Review main Merged

65351[BUGFIX] Type check extbase parameter for array

Remo H. CR +2 V +2 Easy +41 −0 updated 05/04/21, 11:57

Commit message

If an argument on a plugin namespace is not an array,
Extbase failed hard with an type error exception.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2028

Show 23 earlier messages
  1. Remo H. uploaded patch set 1 08/17/20, 10:07

  2. TYPO3com voted on patch set 1 V -1 08/17/20, 10:07 Completed build in 25s on Mon, 17 Aug, 10:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4728

  3. Alexander Schnitzler wrote 08/19/20, 08:16

    Topic set to extbase
  1. Alexander Schnitzler commented on patch set 1 08/19/20, 08:19

    This doesn't fix the issue mentioned in the ticket but the conversion makes sense anyway. Please run ./Build/Scripts/cglFixMyCommit.sh and re-upload the patch.
  2. Jörg Bösche uploaded patch set 2 08/26/20, 13:36

  3. TYPO3com voted on patch set 2 V -1 08/26/20, 14:09 Completed build in 31m 13s on Wed, 26 Aug, 02:09 PM Test Summary: 1 of 73581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4988

  4. TYPO3com commented on patch set 2 08/26/20, 15:12 Completed build in 25m 02s on Wed, 26 Aug, 03:12 PM Test Summary: 73095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4994

  5. Remo H. rebased onto patch set 3 08/28/20, 06:29

  6. TYPO3com voted on patch set 3 V +1 08/28/20, 06:40 Completed build in 10m 51s on Fri, 28 Aug, 06:40 AM Test Summary: 73095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5021

  7. Benni Mack uploaded patch set 4 04/30/21, 17:55

  8. core-ci voted on patch set 4 V +1 04/30/21, 18:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10981

  9. Oliver Klee commented on patch set 5 04/30/21, 22:38

    Published edit on patch set 4.
  10. Oliver Klee voted on patch set 5 CR +1 04/30/21, 22:38

  11. core-ci voted on patch set 5 V +1 04/30/21, 22:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10990

  12. Oli Bartsch commented on patch set 5 04/30/21, 22:57

    RequestBuilder.php:183

    I wonder how this passed CGL
  13. Oli Bartsch commented on patch set 5 04/30/21, 23:02

    RequestBuilder.php:185

    Isn't the is_array check also required here?
  14. Andreas Kienast commented on patch set 5 CR -1 05/02/21, 11:25

    on it

    RequestBuilder.php:183 Reply Unresolved

    This is either a bug in the CGL fixer or the config needs some adjustments.

    RequestBuilder.php:185 Reply Unresolved

    wouldn't hurt, I guess
  15. Andreas Kienast uploaded patch set 6 05/02/21, 11:26

  16. Andreas Kienast voted on patch set 6 CR +1 05/02/21, 11:26

  17. core-ci voted on patch set 6 V +1 05/02/21, 11:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11035

  18. Benni Mack voted on patch set 6 V +1 CR +1 05/04/21, 09:58

  19. Oli Bartsch uploaded patch set 7 05/04/21, 10:45

  20. Oliver Klee voted on patch set 7 CR +1 05/04/21, 10:45

  21. Oli Bartsch voted on patch set 7 V +1 CR +1 05/04/21, 10:46

  22. core-ci voted on patch set 7 V +1 05/04/21, 10:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11094

  23. Benni Mack voted on patch set 7 V +1 CR +1 05/04/21, 11:44

  24. Oli Bartsch voted on patch set 7 V +2 CR +2 05/04/21, 11:57

  25. Oli Bartsch merged patch set 8 05/04/21, 11:57