65351[BUGFIX] Type check extbase parameter for array
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2028
Show 23 earlier messages
-
Remo H. uploaded patch set 1 08/17/20, 10:07
-
TYPO3com voted on patch set 1 V -1 08/17/20, 10:07 Completed build in 25s on Mon, 17 Aug, 10:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4728
-
Alexander Schnitzler wrote 08/19/20, 08:16
Topic set to extbase
-
Alexander Schnitzler commented on patch set 1 08/19/20, 08:19
This doesn't fix the issue mentioned in the ticket but the conversion makes sense anyway. Please run ./Build/Scripts/cglFixMyCommit.sh and re-upload the patch. -
Jörg Bösche uploaded patch set 2 08/26/20, 13:36
-
TYPO3com voted on patch set 2 V -1 08/26/20, 14:09 Completed build in 31m 13s on Wed, 26 Aug, 02:09 PM Test Summary: 1 of 73581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4988
-
TYPO3com commented on patch set 2 08/26/20, 15:12 Completed build in 25m 02s on Wed, 26 Aug, 03:12 PM Test Summary: 73095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4994
-
Remo H. rebased onto patch set 3 08/28/20, 06:29
-
TYPO3com voted on patch set 3 V +1 08/28/20, 06:40 Completed build in 10m 51s on Fri, 28 Aug, 06:40 AM Test Summary: 73095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5021
-
Benni Mack uploaded patch set 4 04/30/21, 17:55
-
core-ci voted on patch set 4 V +1 04/30/21, 18:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10981
-
Oliver Klee commented on patch set 5 04/30/21, 22:38
Published edit on patch set 4. -
Oliver Klee voted on patch set 5 CR +1 04/30/21, 22:38
-
core-ci voted on patch set 5 V +1 04/30/21, 22:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10990
-
Oli Bartsch commented on patch set 5 04/30/21, 22:57
RequestBuilder.php:183I wonder how this passed CGL -
Oli Bartsch commented on patch set 5 04/30/21, 23:02
RequestBuilder.php:185Isn't the is_array check also required here? -
Andreas Kienast commented on patch set 5 CR -1 05/02/21, 11:25
on itRequestBuilder.php:183Reply UnresolvedThis is either a bug in the CGL fixer or the config needs some adjustments.RequestBuilder.php:185Reply Unresolvedwouldn't hurt, I guess -
Andreas Kienast uploaded patch set 6 05/02/21, 11:26
-
Andreas Kienast voted on patch set 6 CR +1 05/02/21, 11:26
-
core-ci voted on patch set 6 V +1 05/02/21, 11:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11035
-
Benni Mack voted on patch set 6 V +1 CR +1 05/04/21, 09:58
-
Oli Bartsch uploaded patch set 7 05/04/21, 10:45
-
Oliver Klee voted on patch set 7 CR +1 05/04/21, 10:45
-
Oli Bartsch voted on patch set 7 V +1 CR +1 05/04/21, 10:46
-
core-ci voted on patch set 7 V +1 05/04/21, 10:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11094
-
Benni Mack voted on patch set 7 V +1 CR +1 05/04/21, 11:44
-
Oli Bartsch voted on patch set 7 V +2 CR +2 05/04/21, 11:57
-
Oli Bartsch merged patch set 8 05/04/21, 11:57