Review main Merged

65353[BUGFIX] Handle missing files in ImageService

Kevin Ditscheid CR +2 V +2 Easy +14 −5 updated 08/19/20, 17:52

Commit message

This commit hardens the extbase ImageService to not
hard crash if $processedImage->getPublicUrl() returns
a NULL value.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Kevin Ditscheid uploaded patch set 1 08/17/20, 12:34

  2. TYPO3com voted on patch set 1 V +1 08/17/20, 12:45 Completed build in 10m 41s on Mon, 17 Aug, 12:45 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4731

  3. Kevin Ditscheid uploaded patch set 2 08/18/20, 12:22

  4. TYPO3com voted on patch set 2 V +1 08/18/20, 12:33 Completed build in 11m 41s on Tue, 18 Aug, 12:33 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4757

  5. Markus Klein commented on patch set 2 08/18/20, 12:43

    Handle missing files in ImageService would be my suggestions
  6. Markus Klein commented on patch set 2 08/18/20, 12:44

    ImageService.php:111

    $imageUrl can be '' now, so I would return an empty string as well instead of just the prefix
  7. Kevin Ditscheid uploaded patch set 3 08/18/20, 18:48

  8. Kevin Ditscheid commented on patch set 3 08/18/20, 18:50

    ImageService.php:111 Reply

    Actually I reworked the solution a bit for the problematic usages
  9. TYPO3com voted on patch set 3 V +1 08/18/20, 19:04 Completed build in 13m 55s on Tue, 18 Aug, 07:04 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4770

  10. Markus Klein commented on patch set 3 V +1 CR +1 08/19/20, 07:22

    Reply

    Done

    ImageService.php:111 Reply

    Done
  11. Alexander Schnitzler wrote 08/19/20, 08:19

    Topic set to extbase
  12. Daniel Goerz voted on patch set 3 V +2 CR +2 08/19/20, 17:52

  13. Daniel Goerz merged patch set 4 08/19/20, 17:52