65355[BUGFIX] Limit amount of data fetched by the page tree
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Andreas Kienast +1
-
Verified V +2 Done
- Richard Haeser +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 6
- Bug #88943Pagetree taking extremely long to load for editors
- Bug #88098Page tree XHR is fetching huge JSON data
- Bug #88259Filtered pagetree should display child pages
- Bug #91884Page tree filter has no delete "X", needs hitting enter and has no filter info box anymore, a big backwards step regarding usability
- Bug #91753Pagetree not respecting getPagePermsClause()
- Task #91916Provide acceptance tests for page tree filter
Files 16
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+160 −49
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+348 −10
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+6 −0
- typo3/sysext/backend/Resources/Private/TypeScript/Viewport/NavigationComponentInterface.ts+1 −1
- typo3/sysext/backend/Resources/Private/TypeScript/Viewport/PageTree.ts+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+129 −4
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeToolbar.js+26 −38
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/PageTree.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+98 −55
- typo3/sysext/core/Tests/Acceptance/Backend/PageTree/PageTreeFilterCest.phpnew+151 −0
- typo3/sysext/core/Tests/Acceptance/Support/Helper/PageTree.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Helper/SiteConfiguration.phpnew+39 −0
- typo3/sysext/core/composer.json+1 −1
- composer.json+1 −1
- composer.lock+7 −342
Review log 1316
-
Andreas Kienast uploaded patch set 1 08/17/20, 13:32
-
TYPO3com voted on patch set 1 V -1 08/17/20, 13:45 Completed build in 13m 32s on Mon, 17 Aug, 01:45 PM Test Summary: 3 of 75745 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-760
-
Andreas Kienast commented on patch set 1 08/17/20, 13:50
The used testing-framework version misses at least this commit: https://github.com/TYPO3/testing-framework/commit/43709b2855f66e4ba36c584873836ebf8cd88e74 -
Richard Haeser commented on patch set 1 V +1 CR +1 08/17/20, 13:53
Manual test works quite nice with 150k+ pages -
Sven Juergens voted on patch set 1 V +1 08/17/20, 14:40
-
Anja Leichsenring commented on patch set 1 08/17/20, 17:23
I am busy on providing the backport of testing-framework change needed -
Anja Leichsenring uploaded patch set 2 08/17/20, 17:51
-
Anja Leichsenring commented on patch set 2 V -1 08/17/20, 17:52
I adapted test and testing-framework, but we will still need a release of testing-framework. For now, let's see what bamboo thinks. -
TYPO3com voted on patch set 2 V +1 08/17/20, 18:03 Completed build in 11m 56s on Mon, 17 Aug, 06:03 PM Test Summary: 75145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-761
-
Richard Haeser commented on patch set 2 V +1 CR +1 08/17/20, 19:28
Just to let you know that the patch is working fine. We only wait on release of testing framework -
Anja Leichsenring uploaded patch set 3 08/17/20, 20:14
-
TYPO3com voted on patch set 3 V +1 08/17/20, 20:27 Completed build in 13m 12s on Mon, 17 Aug, 08:27 PM Test Summary: 75145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-762
-
Richard Haeser voted on patch set 3 V +1 CR +1 08/17/20, 20:27
-
Andreas Kienast voted on patch set 3 V +1 CR +1 08/17/20, 20:28
-
Richard Haeser voted on patch set 3 V +2 CR +2 08/17/20, 20:33
-
Richard Haeser merged patch set 4 08/17/20, 20:33