Review main Merged

65356[BUGFIX] Keep FE cookie expire time correct

Markus Klein CR +2 V +2 Easy +2 −2 updated 08/18/20, 19:21

Commit message

Using FE permalogin sets a cookie expire time once. While the session
timestamp on the server side is updated continuously to keep a session
alive. This led to the situation that an actually valid session was
abandoned due to cookie expiry.

The code is adjusted to always update an existing cookie if it is a
non-session cookie.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Markus Klein uploaded patch set 1 08/17/20, 13:46

  2. TYPO3com voted on patch set 1 V +1 08/17/20, 13:58 Completed build in 11m 22s on Mon, 17 Aug, 01:57 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4732

  3. Richard Haeser voted on patch set 1 CR +1 08/17/20, 18:58

  4. Christian Kuhn updated the commit message in patch set 2 08/18/20, 18:07

  5. Christian Kuhn commented on patch set 2 08/18/20, 18:07

    ok with me, but imho not critical enough for 9.5
  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/18/20, 18:07

  7. TYPO3com voted on patch set 2 V +1 08/18/20, 18:18 Completed build in 11m 36s on Tue, 18 Aug, 06:18 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4766

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/18/20, 19:21

  9. Anja Leichsenring merged patch set 3 08/18/20, 19:21