Review main Merged

65358[BUGFIX] Do not create Install Tool cookie if not needed

Markus Klein CR +2 V +2 Normal +89 −65 updated 09/04/20, 13:01

Commit message

This change corrects the Install Tool cookie handling in various ways:

1.) It is ensured that the cookie is removed on log off
2.) Session files (var/session/*) are always removed
3.) No cookie is set until it is really needed (during login)
4.) Session expire calculation is centralized into a single method

This is done by adjusting the SessionService:
 - Move session_start() from the constructor to a dedicated method
 - Session existence check employs a cookie existence check
   before loading an existing session into memory and validating it
 - destroySession() now explicitly removes the cookie
 - renewSession() lets session_regenerate_id() deleted old session data

The Install Tool is adjusted to separate action treatment for actions
requiring session interaction and those not.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1116

  1. Markus Klein uploaded patch set 1 08/17/20, 17:00

  2. TYPO3com voted on patch set 1 V -1 08/17/20, 17:01 Completed build in 24s on Mon, 17 Aug, 05:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4737

  3. Markus Klein uploaded patch set 2 08/17/20, 17:03

  4. TYPO3com voted on patch set 2 V -1 08/17/20, 17:03 Completed build in 24s on Mon, 17 Aug, 05:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4738

  5. Markus Klein uploaded patch set 3 08/17/20, 17:09

  6. TYPO3com voted on patch set 3 V -1 08/17/20, 17:09 Completed build in 26s on Mon, 17 Aug, 05:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4739

  7. Markus Klein uploaded patch set 4 08/17/20, 17:10

  8. TYPO3com voted on patch set 4 V +1 08/17/20, 17:24 Completed build in 13m 45s on Mon, 17 Aug, 05:24 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4740

  9. Oliver Hader commented on patch set 4 08/17/20, 17:41

    I'm not sure/convinced whether this should go to 9.5 as well...
  10. Markus Klein commented on patch set 4 08/17/20, 18:42

    > Patch Set 4: > > I'm not sure/convinced whether this should go to 9.5 as well... No hard feelings. Lets skip v9 then
  11. Markus Klein updated the commit message in patch set 5 08/17/20, 18:42

  12. TYPO3com voted on patch set 5 V +1 08/17/20, 18:54 Completed build in 11m 16s on Mon, 17 Aug, 06:53 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4742

  13. Benni Mack voted on patch set 5 CR +1 09/03/20, 14:47

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 09/03/20, 19:15

  15. Benni Mack voted on patch set 5 V +2 CR +2 09/04/20, 13:01

  16. Benni Mack merged patch set 6 09/04/20, 13:01